Skip to content

[ads] Fixes Clear Brave Ads data in brave://settings/clearBrowserData does not work #29107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented May 16, 2025

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 16, 2025
@tmancey
Copy link
Collaborator

tmancey commented May 16, 2025

@aseren, based on this fix, are there any other areas you think could be impacted that we might also need to address?

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@aseren aseren enabled auto-merge (squash) May 16, 2025 22:41
@aseren
Copy link
Collaborator Author

aseren commented May 16, 2025

@aseren, based on this fix, are there any other areas you think could be impacted that we might also need to address?

@tmancey, no any other areas to change that I'm aware of. I went through settings and didn't find anything other, which is related to ads.

@aseren aseren merged commit f540067 into master May 16, 2025
21 checks passed
@aseren aseren deleted the issues/46132 branch May 16, 2025 23:13
@github-actions github-actions bot added this to the 1.80.x - Nightly milestone May 16, 2025
brave-builds added a commit that referenced this pull request May 16, 2025
@brave-builds
Copy link
Collaborator

Released in v1.80.76

@btlechowski
Copy link

Verified with

Brave 1.80.76 Chromium: 137.0.7151.27 (Official Build) nightly (64-bit)
Revision 9b807fc
OS Linux

Verified Active Brave Ads events is populated

image

Verified Clear Brave Ads data is shown

image

Verified data is cleared

image

@btlechowski
Copy link

Verification passed on Brave v1.80.76 on Lenovo TB-8506FS (Android 11.0)

Verified Active Brave Ads events is populated

image

Verified Clear Brave Ads data is shown

image

Verified data is cleared

image

@btlechowski
Copy link

Verification passed on 1.80.76 on iPhone 13 Pro Max (iOS 18.4)

Verified Active Brave Ads events is populated

image

Verified Clear Brave Ads data is shown

image

Verified data is cleared

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ads] Clear Brave Ads data in brave://settings/clearBrowserData does not work
5 participants