Applied our resize area to BraveMultiContentsView #29154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
added
the
CI/run-upstream-tests
simonhong
commented
May 21, 2025
| class BrowserView; | ||
| class ContentsWebView; | ||
| -class MultiContentsResizeArea; | ||
| +// class MultiContentsResizeArea; |
There was a problem hiding this comment.
This redefine #define MultiContentsResizeArea views::ResizeArea makes build error.
can't build class views::ResizeArea;
simonhong
force-pushed
the
use_our_resize_area_in_multi_contents_view
branch
2 times, most recently
from
3a17f86 to
7a98ae6
Compare
simonhong
assigned simonhong and unassigned thypon, simonhong, stoletheminerals and cdesouza-chromium
fix brave/brave-browser#46194 TEST=SideBySideEnabledBrowserTest.BraveMultiContentsViewTest
simonhong
force-pushed
the
use_our_resize_area_in_multi_contents_view
branch
from
7a98ae6 to
a29207b
Compare
browser/ui/views/frame/split_view/brave_multi_contents_view_separator_delegate.h
Outdated
Show resolved
Hide resolved
fallaciousreasoning
approved these changes
May 25, 2025
goodov
approved these changes
May 26, 2025
|
Released in v1.81.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix brave/brave-browser#46194
Replaced
MultiContentsResizeAreawithSplitViewSeparatorto use our resizer UI inBraveMultiContentsView.TEST=SideBySideEnabledBrowserTest.BraveMultiContentsViewTest
--enable-features=SidebySideResolves