Skip to content

[canary] Stop removing empty line in package.json #29155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2025

Conversation

cdesouza-chromium
Copy link
Collaborator

This for some reason only started being an issue now, but basically we have to make sure that an empty line is left at the end of package.json, otherwise we get presubmit failures.

Resolves brave/brave-browser#46229

This for some reason only started being an issue now, but basically we
have to make sure that an empty line is left at the end of
`package.json`, otherwise we get presubmit failures.

Resolves brave/brave-browser#46229
@cdesouza-chromium cdesouza-chromium self-assigned this May 21, 2025
@cdesouza-chromium cdesouza-chromium requested a review from a team as a code owner May 21, 2025 10:01
@cdesouza-chromium cdesouza-chromium added the CI/skip Do not run CI builds (except noplatform) label May 21, 2025
@cdesouza-chromium cdesouza-chromium merged commit 339b9fe into master May 21, 2025
19 checks passed
@cdesouza-chromium cdesouza-chromium deleted the canary+issue-46229 branch May 21, 2025 10:26
@github-actions github-actions bot added this to the 1.80.x - Nightly milestone May 21, 2025
@brave-builds
Copy link
Collaborator

Released in v1.80.86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brockit is removing the empty line in package.json
3 participants