Resource URL generated by content-plugin needs to be improved #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

dsimko opened this issue Feb 13, 2017 · 0 comments

Member

dsimko commented Feb 13, 2017

Korbinian's notes on #3:

I'm not sure you really want the URLs made by that...
e.g.: http://46.183.65.66:8080/content-plugin/bx_ZpWFOgGGBwmZbuHQxLkERLgc/5da7028e-19b5-4014-8bc0-fcf8484d4f0b
or http://46.183.65.66:8080/content-plugin/bx_ZpWFOgGGBwmZbuHQxLkERLgc/0193ac81-6efa-48d2-b995-a304fbbcefa1

is IMHO nightmare for any seo strategy... also from my wordpress experience one often reuses media files like images over more than 1 blog post...
beside, I'm not sure that exposing the workspace name/id is a good idea in terms of security (I know that security by obscurity is also a bad idea ;) )

maybe a distinct media workspaceor plugin would be better?
path then could be:

http://127.0.0.1/media-plugin/path/to/file/file.png

where "/media-plugin" could be configured on the plugin level in code...
or you use a reference to the site-workspace and allow to link images from there?

dsimko mentioned this issue

Adding support for files to the content-plugin #3

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment