Skip to content

Stop using browniebroke/renovate-configs? #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
2 of 5 tasks
34j opened this issue Apr 15, 2025 · 2 comments · May be fixed by #949
Open
2 of 5 tasks

Stop using browniebroke/renovate-configs? #939

34j opened this issue Apr 15, 2025 · 2 comments · May be fixed by #949
Labels
enhancement New feature or request

Comments

@34j
Copy link
Contributor

34j commented Apr 15, 2025

Is your feature request related to a problem? Please describe.

browniebroke/renovate-configs have the following problems

  • No documentation, not sure what is included, very "personal" unfortunately
  • Javascript-related configs are mixed in.
  • When you make personal changes, all repositories are affected

Therefore I would like to suggest that you isolate the python configs and paste them to renovate.json in this repository. This is also consistent with the fact that this repository does not use reusable workflows for GitHub Actions.

Describe alternatives you've considered

isolate the python configs and paste them to renovate.json in this repository

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct

Are you willing to resolve this issue by submitting a Pull Request?

  • Yes, I have the time, and I know how to start.
  • Yes, I have the time, but I don't know how to start. I would need guidance.
  • No, I don't have the time, although I believe I could do it if I had the time...
  • No, I don't have the time and I wouldn't even know how to start.
@34j 34j added the enhancement New feature or request label Apr 15, 2025
@browniebroke
Copy link
Owner

  • No documentation, not sure what is included, very "personal" unfortunately

Yes, that's fair. I'm the main customer here, so very personal indeed. Documentation is here

  • Javascript-related configs are mixed in.

The generated project use the python config:

"extends": ["github>browniebroke/renovate-configs:python"]

When you make personal changes, all repositories are affected

Yes it's a feature, not a bug 😄

However, in the spirit of making this template more generic to others, I'm open to let users choose a more "default" renovate config, not referencing my own.

@34j
Copy link
Contributor Author

34j commented Apr 17, 2025

I looked a little deeper into your config and have a few questions:

  • I am unsure of the need for no-pip-requirements. There is no requirements.txt in the template.
  • If boto3, httpx, and sphinx packages are not grouped together, will the automatic updates stop working properly? (And I think these should be configured by the users themselves (except for the deps of sphinx and django (I'm not sure which one are they though)))
  • I think github>browniebroke/renovate-configs:automerge can be replaced with config:automergeMinor. (And why not use config:automergeAll?)
  • Why not follow Renovate's recommendation and use config:js-lib (or ["config:best-practices", ":pinOnlyDevDependencies"])? In particular, why not follow Renovate's recommendation to pin devDependencies?
  • What is the advantage of letting pre-commit.ci update pre-commit dependencies instead of Renovate? Wouldn't it just stop automerge and make it more cumbersome?

python.json

{
  "extends": [
    "github>browniebroke/renovate-configs",
    "github>browniebroke/renovate-configs:cpython",
    "github>browniebroke/renovate-configs:no-pip-requirements",
    "github>browniebroke/renovate-configs:boto3",
    "github>browniebroke/renovate-configs:httpx",
    "github>browniebroke/renovate-configs:sphinx"
  ]
}

default.json

{
  "extends": [
    "config:base", 
    "github>browniebroke/renovate-configs:automerge"
  ],
  "labels": ["dependencies"],
  "pre-commit": {
    "enabled": true
  }
}

@34j 34j linked a pull request May 1, 2025 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants