fix: ignore the entire .idea folder
#938
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34j
changed the title
34j
changed the title
.idea folder
Comment on lines
+98
to
+119
| # UV | ||
| # Similar to Pipfile.lock, it is generally recommended to include uv.lock in version control. | ||
| # This is especially recommended for binary packages to ensure reproducibility, and is more | ||
| # commonly ignored for libraries. | ||
| #uv.lock | ||
|
|
||
| # poetry | ||
| # Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. | ||
| # This is especially recommended for binary packages to ensure reproducibility, and is more | ||
| # commonly ignored for libraries. | ||
| # https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control | ||
| #poetry.lock | ||
|
|
||
| # pdm | ||
| # Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. | ||
| #pdm.lock | ||
| # pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it | ||
| # in version control. | ||
| # https://pdm.fming.dev/latest/usage/project/#working-with-version-control | ||
| .pdm.toml | ||
| .pdm-python | ||
| .pdm-build/ |
There was a problem hiding this comment.
That out of scope on this PR, please revert
There was a problem hiding this comment.
I just copy pasted the latest .gitignore so that I can use the .idea nuclear option, but should I still remove it?
project/.idea/watcherTasks.xml
Outdated
There was a problem hiding this comment.
Please leave these files, they are here for a reason, it's because they pre-configure the PyCharm workspace.
There was a problem hiding this comment.
Do you still want it to be .gitignore ed?
There was a problem hiding this comment.
If not, JetBrains.gitignore needs to be used as well, I suppose
And I'm a bit against adding editor-specific confugurations
There was a problem hiding this comment.
Do you still want it to be .gitignore ed?
Yes, no problems with that. I actually ignore it in my system level config :) It's just that it's useful to have a starting config on my machine 😄
34j
commented
Apr 17, 2025
Comment on lines
+98
to
+121
| # UV | ||
| # Similar to Pipfile.lock, it is generally recommended to include uv.lock in version control. | ||
| # This is especially recommended for binary packages to ensure reproducibility, and is more | ||
| # commonly ignored for libraries. | ||
| #uv.lock | ||
|
|
||
| # poetry | ||
| # Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. | ||
| # This is especially recommended for binary packages to ensure reproducibility, and is more | ||
| # commonly ignored for libraries. | ||
| # https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control | ||
| #poetry.lock | ||
|
|
||
| # pdm | ||
| # Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. | ||
| #pdm.lock | ||
| # pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it | ||
| # in version control. | ||
| # https://pdm.fming.dev/latest/usage/project/#working-with-version-control | ||
| .pdm.toml | ||
| .pdm-python | ||
| .pdm-build/ | ||
|
|
||
| # PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm |
There was a problem hiding this comment.
Suggested change
| # UV | |
| # Similar to Pipfile.lock, it is generally recommended to include uv.lock in version control. | |
| # This is especially recommended for binary packages to ensure reproducibility, and is more | |
| # commonly ignored for libraries. | |
| #uv.lock | |
| # poetry | |
| # Similar to Pipfile.lock, it is generally recommended to include poetry.lock in version control. | |
| # This is especially recommended for binary packages to ensure reproducibility, and is more | |
| # commonly ignored for libraries. | |
| # https://python-poetry.org/docs/basic-usage/#commit-your-poetrylock-file-to-version-control | |
| #poetry.lock | |
| # pdm | |
| # Similar to Pipfile.lock, it is generally recommended to include pdm.lock in version control. | |
| #pdm.lock | |
| # pdm stores project-wide configurations in .pdm.toml, but it is recommended to not include it | |
| # in version control. | |
| # https://pdm.fming.dev/latest/usage/project/#working-with-version-control | |
| .pdm.toml | |
| .pdm-python | |
| .pdm-build/ | |
| # PEP 582; used by e.g. github.com/David-OConnor/pyflow and github.com/pdm-project/pdm |
34j
commented
Apr 17, 2025
Comment on lines
+164
to
+176
| # PyCharm | ||
| # JetBrains specific template is maintained in a separate JetBrains.gitignore that can | ||
| # be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore | ||
| # and can be added to the global gitignore or merged into this file. For a more nuclear | ||
| # option (not recommended) you can uncomment the following to ignore the entire idea folder. | ||
| .idea/ | ||
|
|
||
| # Ruff stuff: | ||
| .ruff_cache/ | ||
|
|
||
| # PyPI configuration file | ||
| .pypirc | ||
|
|
There was a problem hiding this comment.
Suggested change
| # PyCharm | |
| # JetBrains specific template is maintained in a separate JetBrains.gitignore that can | |
| # be found at https://github.com/github/gitignore/blob/main/Global/JetBrains.gitignore | |
| # and can be added to the global gitignore or merged into this file. For a more nuclear | |
| # option (not recommended) you can uncomment the following to ignore the entire idea folder. | |
| .idea/ | |
| # Ruff stuff: | |
| .ruff_cache/ | |
| # PyPI configuration file | |
| .pypirc |
34j
commented
Apr 17, 2025
| @@ -1,5 +1,4 @@ | |||
| # Created by .ignore support plugin (hsz.mobi) | |||
| ### Python template | |||
| # https://github.com/github/gitignore/blob/main/Python.gitignore | |||
There was a problem hiding this comment.
Suggested change
| # https://github.com/github/gitignore/blob/main/Python.gitignore | |
| # Created by .ignore support plugin (hsz.mobi) | |
| ### Python template |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Since contributors to the repository may not all be JetBrains users, the .idea folder will not reflect the latest changes and become outdated, which is not good for anyone.
Pull-Request Checklist
mainbranchFixes #0000