promises #78
Merged
promises #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MiguelSolano This would be a big improvement. To be able to use promises and async/await. This is fully backwards compatible. If a callback is given the asynchronous functions act the same as before. If no callback is given they return a promise instead of undefined. Can we get this merged? |
Closed
|
Hi @UziTech, I wonder if you've seen https://github.com/benjamingr/tmp-promise. It's an established solution that wraps this library, and is widely used. It has an expressive interface that includes a cleanup function, and a few tests. What do you think about that interface? |
|
I believe |
|
Ha! You're right. |
ghost
self-requested a review
ghost
added
the
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Async functions return a promise unless a callback is provided