Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSS grid classes completely #183

Open
5 of 57 tasks
bruvellu opened this issue Jun 3, 2023 · 1 comment · Fixed by #186
Open
5 of 57 tasks

Remove CSS grid classes completely #183

bruvellu opened this issue Jun 3, 2023 · 1 comment · Fixed by #186
Assignees
@bruvellu
Labels
bug Issues with bugs that need to be fixed

Comments

@bruvellu
Copy link
Owner

bruvellu commented Jun 3, 2023 •
edited
Loading

We are deprecating the grid-based CSS framework (Blueprint) in favour of a responsive layout. All the associated classes should probably be removed to avoid issues and inconsistencies in the template rendering.

Grid-related classes: span-1 to span-24, container (?), column, last, append-1 to append-24, prepend-1 to prepend-24, border (?), colborder, pull-1 to pull-24, push-1 to push-24, prepend-top, append-bottom, box (?).

(?) marks more generic classes, perhaps don't remove

Templates that need revision:

  • base.html
  • home.html
  • nav.html
  • header.html
  • footer.html
  • tags_page.html
  • taxa_page.html
  • tours_page.html
  • authors_page.html
  • places_page.html
  • flatpages/default.html
  • tour_page.html
  • meta_page.html
  • 404.html
  • 500.html
  • admin_tools.html
  • author_list.html
  • author_list_page.html
  • biodb.html
  • buscar.html
  • disqus.html
  • embed.html
  • fino.html
  • fixmedia.html
  • fixtaxa.html
  • gallery.html
  • hidden.html
  • mais.html
  • media_page_ajax.html
  • media_page.html
  • messages.html
  • meta_list.html
  • metalist.html
  • meta_list_page.html
  • organization.html
  • pagination.html
  • photo.html
  • press_page.html
  • refs_page.html
  • registration/login.html
  • related.html
  • search_box.html
  • search.html
  • sets.html
  • sobremenu.html
  • social.html
  • splist.html
  • stats.html
  • tag_list.html
  • tag_list_page.html
  • taxon_paths.html
  • thumb.html
  • thumb_org.html
  • tour_entry.html
  • tree.html
  • tudo.html
  • video.html
@bruvellu bruvellu added the bug Issues with bugs that need to be fixed label Jun 3, 2023
bruvellu added a commit that referenced this issue Jun 3, 2023
@bruvellu
Remove old CSS grid classes from base.html, #183
e9d33c6
bruvellu added a commit that referenced this issue Jun 3, 2023
@bruvellu
Revise styling IDs for cover image and text, #183
a898f4d 
In addition to removing grid classes, I've also renamed the IDs for
consistency and moved a rule from `style.css` to the `home.css`.
Repository owner deleted a comment from mohNourBoshi Jun 3, 2023
bruvellu added a commit that referenced this issue Jun 3, 2023
@bruvellu
Remove old grid classes in home main content, #183
bc86ee0 
After removing the span-8 classes I had to add a display:grid rule. I
used the same as used in the #sitelinks for now. Also made some tweaks
to the font sizes and removed text justification.
@bruvellu bruvellu linked a pull request Jun 5, 2023 that will close this issue
Remove old css grid from base and home #186
Merged
@bruvellu bruvellu reopened this Jun 6, 2023
bruvellu added a commit that referenced this issue Jun 8, 2023
@bruvellu
Move about menu styles to nav.css, #183
488ab43
@bruvellu bruvellu mentioned this issue Jun 13, 2023
Closed
bruvellu added a commit that referenced this issue Jun 13, 2023
@bruvellu
Move maintitle/tagline styles to header.css, #183
b3cb3c6
bruvellu added a commit that referenced this issue Jun 13, 2023
@bruvellu
Move stats styles to header.css, #183
3ecd240
@bruvellu bruvellu self-assigned this Dec 6, 2024
@bruvellu
Copy link
Owner Author

bruvellu commented Dec 7, 2024

Tweaked tour page here 8247ab3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bruvellu bruvellu

Labels
bug Issues with bugs that need to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove old css grid from base and home bruvellu/cifonauta
1 participant
@bruvellu