Remove old css grid from base and home #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to removing grid classes, I've also renamed the IDs for consistency and moved a rule from `style.css` to the `home.css`.
After removing the span-8 classes I had to add a display:grid rule. I used the same as used in the #sitelinks for now. Also made some tweaks to the font sizes and removed text justification.
bruvellu
requested review from
RianPolonini,
joaopedrodiniz,
ArthurSimoesFerreira and
Felyppe1
57 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the CSS classes of the old grid framework from
base.htmlandhome.html, and moved the page-specific styles fromstyle.css.