Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Ember 4x #110

Open
nathanielasare opened this issue Mar 3, 2023 · 5 comments
Open

Support for Ember 4x #110

nathanielasare opened this issue Mar 3, 2023 · 5 comments

Comments

@nathanielasare
Copy link

nathanielasare commented Mar 3, 2023

Upgrading ember to 3.28.11 gives the warning below, and disabling jquery optional-features in favour of @ember/jquery breaks the picker.

WARNING: Setting the jquery-integration optional feature flag to true, or not providing a setting at all, has been deprecated. You must add the @ember/optional-features addon and set this feature to false. This warning will become an error in Ember 4.0.0.

I'm suppose to upgrade to ^4.4 and need a work around to get the date-picker to work with jquery-integration set to false. Thanks

@btecu
Copy link
Owner

btecu commented Mar 3, 2023

Are you trying to remove jQuery?
Unfortunately, https://github.com/Eonasdan/bootstrap-datetimepicker uses jQuery so it won't work without it.

@nathanielasare
Copy link
Author

Are you trying to remove jQuery? Unfortunately, https://github.com/Eonasdan/bootstrap-datetimepicker uses jQuery so it won't work without it.

I'm trying to disable jQuery app wide and enable it when needed with @ember/jquery in components

@btecu
Copy link
Owner

btecu commented Mar 5, 2023

As long as window.$ is set to jQuery, it should probably work.

@nathanielasare
Copy link
Author

window.$ is set to jQuery

That is what I'm trying to avoid

@btecu
Copy link
Owner

btecu commented Mar 6, 2023

That won't work because this addon uses the library https://github.com/Eonasdan/bootstrap-datetimepicker, which requires jQuery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants