Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slide title & caption below slide image #27

Open
awbauer opened this issue Feb 5, 2016 · 4 comments
Open

Slide title & caption below slide image #27

awbauer opened this issue Feb 5, 2016 · 4 comments

Comments

@awbauer
Copy link
Collaborator

awbauer commented Feb 5, 2016

From Ron: ENHC0014649

I'd like to explore effort it would take to add another option to BU Slideshow plugin to put the photo headline and caption UNDER the image, rather than overlaying those elements on top of the image.

@gjensen01
Copy link

This is especially an issue for responsive. The caption always needs to float below the image on the mobile view. Currently, that takes a lot of CSS overrides to accomplish.

@ashleykolodziej
Copy link

+1 for this issue. You can see the caption styles here: http://nm.cms-devl.bu.edu/kitchensink/images/slideshow/ (second slideshow, first slide) - try giving it a resize for mobile.

So a couple of other things I see here - you can put in any amount of text in the caption you want, which means you could put in a really, really, really long caption, have the slideshow size to that container, and then have the next caption be only a sentence or so, pushing controls way down the page. A sane(ish) character limit might be a good idea to help mitigate that.

On mobile - if the caption is on top of the photo on mobile, it will almost always cover the entire photo, which is why it'd be best to have the caption below the image by default. Same with title - so making this change would help us out over here in ID quite a bit.

@dg4220
Copy link
Contributor

dg4220 commented Jul 26, 2018

A little late here but I've been doing some work on this recently. Take a look at https://github.com/bu-ist/bu-slideshow/tree/add-cap-below-slide-cssjs and let me know what you think about the approach.

I haven't added text limits or set the caption default but the caption position seems to be working and I'm able to keep navigation positioned with the image.

Demo here http://djgannon.cms-devl.bu.edu/singlecell/carp-quiz/

@dg4220 dg4220 self-assigned this Jul 26, 2018
@dg4220
Copy link
Contributor

dg4220 commented Sep 5, 2018

Quick update same example and branch as above. I've set the below slide caption position as the default when adding a slide caption. I've also added functionality that positions all slide captions below the image when the screen is below an arbitrary width (currently 400px). Adding, I'm not sure if that's necessarily the functionality we're looking for but it seems a good way to solve the usability issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants