tmp 3

Author: bubriks

python/hsfs/constructor/fs_query.py

@@ -99,14 +99,16 @@ def register_external(
             Union[TypeVar("pyspark.sql.DataFrame"), TypeVar("pyspark.RDD")]
         ] = None,
     ) -> None:
-        if self._on_demand_fg_aliases is not None:
-            for external_fg_alias in self._on_demand_fg_aliases:
-                if type(external_fg_alias.on_demand_feature_group).__name__ == "SpineGroup":
-                    external_fg_alias.on_demand_feature_group.dataframe = spine
-                engine.get_instance().register_external_temporary_table(
-                    external_fg_alias.on_demand_feature_group,
-                    external_fg_alias.alias,
-                )
+        if self._on_demand_fg_aliases is None:
+            return
+
+        for external_fg_alias in self._on_demand_fg_aliases:
+            if type(external_fg_alias.on_demand_feature_group).__name__ == "SpineGroup":
+                external_fg_alias.on_demand_feature_group.dataframe = spine
+            engine.get_instance().register_external_temporary_table(
+                external_fg_alias.on_demand_feature_group,
+                external_fg_alias.alias,
+            )
 
     def register_hudi_tables(
         self,

python/hsfs/engine/spark.py

@@ -188,7 +188,7 @@ def set_job_group(self, group_id, description):
         self._spark_session.sparkContext.setJobGroup(group_id, description)
 
     def register_external_temporary_table(self, external_fg, alias):
-        if isinstance(external_fg, fg_mod.ExternalFeatureGroup):
+        if not isinstance(external_fg, fg_mod.SpineGroup):
             external_dataset = external_fg.storage_connector.read(
                 external_fg.query,
                 external_fg.data_format,