Code

Davkutalek/refactor#436

Code

Draft

davkutalek wants to merge 53 commits intobuildkite-plugins:masterbuildkite-plugins/docker-compose-buildkite-plugin:masterfrom joinhandshake:davkutalek/refactorjoinhandshake/docker-compose-buildkite-plugin:davkutalek/refactorCopy head branch name to clipboard

+498-438

Commits

Commits on Apr 24, 2024

• Fix for graceful shutdown option. Don't call docker rm --force until stop has returned

  

  David Kutalek

  authored and

  David Kutalek

  committed
  0782f49

  Copy full SHA for 0782f49

Commits on Apr 25, 2024

• Merge remote-tracking branch 'upstream/master' into davkutalek/premature-kill-fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  853a524

  Copy full SHA for 853a524

• working on testing graceful shutdown fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  af54780

  Copy full SHA for af54780

• fixed broken tests

  

  David Kutalek

  authored and

  David Kutalek

  committed
  bebc54f

  Copy full SHA for bebc54f

Commits on Apr 29, 2024

• try running docker shell arg in [] to use exec mode

  

  David Kutalek

  authored and

  David Kutalek

  committed
  1b6df23

  Copy full SHA for 1b6df23

Commits on Apr 30, 2024

• try graceful compose shutdown

  

  David Kutalek

  authored and

  David Kutalek

  committed
  dc72a0f

  Copy full SHA for dc72a0f

• pass service name arg to stop/wait

  

  David Kutalek

  authored and

  David Kutalek

  committed
  553a8d6

  Copy full SHA for 553a8d6

• exit upon getting term signal, otherwise service restarts

  

  David Kutalek

  authored and

  David Kutalek

  committed
  4dbb936

  Copy full SHA for 4dbb936

• Don't run docker command in subshell, obviously signals wont make it\!

  

  David Kutalek

  authored and

  David Kutalek

  committed
  846e1bc

  Copy full SHA for 846e1bc

• rewrite run.sh to use docker compose exec form. All the tests broke, not sure how to fix...

  

  David Kutalek

  authored and

  David Kutalek

  committed
  e5fd440

  Copy full SHA for e5fd440

• revert previous since it isn't working

  

  David Kutalek

  authored and

  David Kutalek

  committed
  99c0fc3

  Copy full SHA for 99c0fc3

• attempt to run shell script without sh -c which creates new shell

  

  David Kutalek

  authored and

  David Kutalek

  committed
  722c50e

  Copy full SHA for 722c50e

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  47d200d

  Copy full SHA for 47d200d

• try subshell with direct command

  

  David Kutalek

  authored and

  David Kutalek

  committed
  aa1220c

  Copy full SHA for aa1220c

Commits on May 1, 2024

• refactor subshell to make it a little clearer, prevent exitcode -u issue

  

  David Kutalek

  authored and

  David Kutalek

  committed
  8e06129

  Copy full SHA for 8e06129

• try not using a subshell again

  

  David Kutalek

  authored and

  David Kutalek

  committed
  1a5d072

  Copy full SHA for 1a5d072

• trying to clean up run file so I can understand the docker calls

  

  David Kutalek

  authored and

  David Kutalek

  committed
  812ece2

  Copy full SHA for 812ece2

Commits on May 2, 2024

• Remove e flag from file, just gets in the way

  

  David Kutalek

  authored and

  David Kutalek

  committed
  3031858

  Copy full SHA for 3031858

• Tabbing fix, add some logging

  

  David Kutalek

  authored and

  David Kutalek

  committed
  570b262

  Copy full SHA for 570b262

• not sure why exit code is causing exit

  

  David Kutalek

  authored and

  David Kutalek

  committed
  02a77d7

  Copy full SHA for 02a77d7

• Move trap

  

  David Kutalek

  authored and

  David Kutalek

  committed
  4fa1a59

  Copy full SHA for 4fa1a59

• remove root -e

  

  David Kutalek

  authored and

  David Kutalek

  committed
  df849c9

  Copy full SHA for df849c9

• declare array

  

  David Kutalek

  authored and

  David Kutalek

  committed
  73500d8

  Copy full SHA for 73500d8

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  8a41127

  Copy full SHA for 8a41127

• fix circular name issue

  

  David Kutalek

  authored and

  David Kutalek

  committed
  6dad4ad

  Copy full SHA for 6dad4ad

• simplify logic, put run args in an array

  

  David Kutalek

  authored and

  David Kutalek

  committed
  fd19fe4

  Copy full SHA for fd19fe4

• try different syntax

  

  David Kutalek

  authored and

  David Kutalek

  committed
  e3df3ba

  Copy full SHA for e3df3ba

• try different syntax

  

  David Kutalek

  authored and

  David Kutalek

  committed
  79a565e

  Copy full SHA for 79a565e

• try different syntax

  

  David Kutalek

  authored and

  David Kutalek

  committed
  78c7d41

  Copy full SHA for 78c7d41

• try different syntax

  

  David Kutalek

  authored and

  David Kutalek

  committed
  e1d6ba3

  Copy full SHA for e1d6ba3

• add some logging

  

  David Kutalek

  authored and

  David Kutalek

  committed
  0c79c5d

  Copy full SHA for 0c79c5d

• logic fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  fc598aa

  Copy full SHA for fc598aa

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  ae42cf4

  Copy full SHA for ae42cf4

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  000655d

  Copy full SHA for 000655d

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  b2bef76

  Copy full SHA for b2bef76

• revert to non-array since it isn't workingx

  

  David Kutalek

  authored and

  David Kutalek

  committed
  662f6ad

  Copy full SHA for 662f6ad

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  857c525

  Copy full SHA for 857c525

Commits on May 3, 2024

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  83f6a47

  Copy full SHA for 83f6a47

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  b9ccdd6

  Copy full SHA for b9ccdd6

• syntax fix

  

  David Kutalek

  authored and

  David Kutalek

  committed
  b7722ca

  Copy full SHA for b7722ca

• Move err trap, add some logging

  

  David Kutalek

  authored and

  David Kutalek

  committed
  47e78be

  Copy full SHA for 47e78be

• move signal trap, make sure err triggers in places we want it to and not in places we don't

  

  David Kutalek

  authored and

  David Kutalek

  committed
  882e5a3

  Copy full SHA for 882e5a3

• run compose in subshell, move run command generation to it's own file

  

  David Kutalek

  authored and

  David Kutalek

  committed
  d208f69

  Copy full SHA for d208f69

• try running compose commands directly

  

  David Kutalek

  authored and

  David Kutalek

  committed
  eebd7a2

  Copy full SHA for eebd7a2

• revert run cmd

  

  David Kutalek

  authored and

  David Kutalek

  committed
  a991830

  Copy full SHA for a991830

• Don't add name to compose kill

  

  David Kutalek

  authored and

  David Kutalek

  committed
  b7690a6

  Copy full SHA for b7690a6

• send kill to named service

  

  David Kutalek

  authored and

  David Kutalek

  committed
  58ee5e4

  Copy full SHA for 58ee5e4

• send kill using build compose command

  

  David Kutalek

  authored and

  David Kutalek

  committed
  a931a74

  Copy full SHA for a931a74

• try running sleep to see if it restarts

  

  David Kutalek

  authored and

  David Kutalek

  committed
  1151415

  Copy full SHA for 1151415

• fix to prev

  

  David Kutalek

  authored and

  David Kutalek

  committed
  d5e07aa

  Copy full SHA for d5e07aa

• use shell

  

  David Kutalek

  authored and

  David Kutalek

  committed
  305ed1d

  Copy full SHA for 305ed1d

• run regular cmd in subprocess

  

  David Kutalek

  authored and

  David Kutalek

  committed
  3e00061

  Copy full SHA for 3e00061

• try without -T

  

  David Kutalek

  authored and

  David Kutalek

  committed
  1435f76

  Copy full SHA for 1435f76