Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the agent scaler which introduces a new agent endpoint param #1437

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Upgrade the agent scaler which introduces a new agent endpoint param #1437

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af2550
Upgrade the agent scaler which introduces a new agent endpoint param
wolfeidau Jan 20, 2025
555e847
Simplify the Allowed Pattern for agent scaler version.
wolfeidau Jan 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion templates/aws-stack.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,9 @@ Parameters:
BuildkiteAgentScalerVersion:
Description: Version of the buildkite-agent-scaler to use
Type: String
Default: "1.8.0"
AllowedPattern: '^(?:(?:[2-9]|[1-9]\d+)\.\d+\.\d+|1\.(?:[1-9]\d+\.\d+|9\.[1-9]\d*))$'
ConstraintDescription: "The agent scaler release must be greater than 1.9.0 as a new parameter was introduced in 1.9.1"
Default: "1.9.1"

LogRetentionDays:
Type: Number
Expand Down Expand Up @@ -1616,6 +1618,7 @@ Resources:
BuildkiteAgentTokenParameter: !If [ UseCustomerManagedParameterPath, !Ref BuildkiteAgentTokenParameterStorePath, !Ref BuildkiteAgentTokenParameter ]
BuildkiteAgentTokenParameterStoreKMSKey: !If [ UseCustomerManagedKeyForParameterStore, !Ref BuildkiteAgentTokenParameterStoreKMSKey, "" ]
RolePermissionsBoundaryARN: !If [ SetInstanceRolePermissionsBoundaryARN, !Ref InstanceRolePermissionsBoundaryARN, "" ]
AgentEndpoint: !Ref AgentEndpoint
BuildkiteQueue: !Ref BuildkiteQueue
AgentsPerInstance: !Ref AgentsPerInstance
MinSize: !Ref MinSize
Expand Down