Fix transaction implementation in LogState::validate.
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the incorrect transaction implementation for `LogState::validate`. Now `validate` takes ownership of `self` and returns `Result<Self, ValidationError>`. This means that callers that expect to keep the log state following an invalid log entry must clone the state prior to validation. As the in-memory data store is the only store that persists the log state in memory, it now clones the state before validation and updates the log state upon successful validation. For the postgres data store, the log state was loaded from the database and is discarded on error, so no clone is necessary. Fixes bytecodealliance#242.
peterhuene
commented
Feb 7, 2024
calvinrp
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the incorrect transaction implementation for
LogState::validate.Now
validatetakes ownership ofselfand returnsResult<Self, ValidationError>.This means that callers that expect to keep the log state following an invalid log entry must clone the state prior to validation.
As the in-memory data store is the only store that persists the log state in memory, it now clones the state before validation and updates the log state upon successful validation.
For the postgres data store, the log state was loaded from the database and is discarded on error, so no clone is necessary.
Fixes #242.