Keyring defaults #250
Merged
Keyring defaults #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me `&mut self`; updated the `fetch_namespace` to only check local namespace map if operator log does not map the namespace
lann
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When keyring interaction was initially added, federation was not part of warg and now that it is, these changes should simplify keyring interaction a bit.
1.) Add a default signing key to the configuration that will be used whenever a registry specific keyring does not exist.
2.) Add a key list to local config that can be checked for a registry specific key without password prompt to determine whether to prompt a password for the default key or registry specific key.
3.) Remove key names and files
4.) Unrelated to keys, but there's a fix to get auth tokens based on provided registry url flag