RFC95: Generating Study data files (clinical, MAF, MRNA, generic assay data and case lists ONLY) #11482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forus
changed the title
|
To enable streaming for Study Data Export (RFC95). Unlike caching http requests `ContentCachingRequestWrapper` for enabling multiple request body reads, wrapping responses in `ContentCachingResponseWrapper` is not necessary and not used anywhere. The application caching behaviour (with `@Cachable` annotation) does not depend on any of these.
- Introduce long table - Convert records back to pojos. Record fields are mapped by position with mybatis - Write tests for clinical data table - Make conditional Java Config
We do defensieve assumption check to make sure clinical file rows will be formed correctly
forus
force-pushed
the
rfc95-study-download
branch
from
71ea083 to
03bdf0d
Compare
forus
changed the title
toRow() gave different results on the first and subsequent calls. The first calls were made for getting the header only.
They were blocking for the followup rows
MyBatis does not like if result does not have <id ...> If it is not specified, it picks first field as a key. Rows that would have the same key will be skipped!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating the downloadable files on the fly. See more details here https://docs.google.com/document/d/1SQ033yQUc9VJquIuHon1WXnrnaIwORi114Q0daXLrl4/edit?tab=t.0
Describe changes proposed in this pull request:
dynamic_study_export_modeflag is on.Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR