Skip to content

Fix freqency error in Legacy #11490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

fuzhaoyuan
Copy link
Contributor

@fuzhaoyuan fuzhaoyuan commented Apr 9, 2025

Fix #10967
Describe changes proposed in this pull request:

  1. Modified the getAlterationGeneCounts method to filter gene alteration data at the study level
  2. Added a filtering step after the includeFrequencyFunction call, which is where matchingGenePanelIds gets populated
  3. Created a filtered list for each study that only includes genes covered by gene panels in that specific study
  4. Used the filtered list when merging results into the final collection

This implementation achieves the following benefits:

  • Each study only contributes data for genes that are covered in its panels
  • Genes not covered by panels in a particular study are excluded from that study's results
  • The final result only contains genes that are covered by at least one panel in at least one study
  • Preserves accurate profiled counts and alteration frequencies
  • Maintains the proper processing flow without disrupting existing functionality

@fuzhaoyuan fuzhaoyuan changed the title Fix multistudies freqency error in Legacy Fix freqency error in Legacy Apr 9, 2025
@fuzhaoyuan fuzhaoyuan self-assigned this Apr 9, 2025
@fuzhaoyuan fuzhaoyuan force-pushed the master-fix-frequency-off-panel-legacy branch from 9889be7 to bb949a3 Compare April 14, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mutation count in combined studies with genepanels seems to be incorrect
1 participant