note on beacon renderer about possible solutions

Author: rfresh2

src/main/java/baritone/utils/PathRenderer.java

@@ -29,7 +29,6 @@
 import com.mojang.blaze3d.vertex.PoseStack;
 import net.minecraft.client.renderer.blockentity.BeaconRenderer;
 import net.minecraft.core.BlockPos;
-import net.minecraft.resources.ResourceLocation;
 import net.minecraft.util.Mth;
 import net.minecraft.world.entity.Entity;
 import net.minecraft.world.level.block.state.BlockState;
@@ -51,9 +50,6 @@
  */
 public final class PathRenderer implements IRenderer {
 
-    private static final ResourceLocation TEXTURE_BEACON_BEAM = ResourceLocation.parse("textures/entity/beacon_beam.png");
-
-
     private PathRenderer() {}
 
     public static double posX() {
@@ -265,20 +261,22 @@ private static void drawGoal(@Nullable BufferBuilder bufferBuilder, PoseStack st
             maxY = ctx.world().getMaxY();
 
             if (settings.renderGoalXZBeacon.value) {
-                //TODO: check
-//                textureManager.getTexture(TEXTURE_BEACON_BEAM).bind();
+                // todo: fix beacon renderer (has been broken since at least 1.20.4)
+                //  issue with outer beam rendering, probably related to matrix transforms state not matching vanilla
+                //  possible solutions:
+                //      inject hook into LevelRenderer#renderBlockEntities where the matrices have already been set up correctly
+                //      copy out and modify the vanilla beacon render code
                 if (settings.renderGoalIgnoreDepth.value) {
-//                    RenderSystem.disableDepthTest();
+
                 }
 
                 stack.pushPose(); // push
                 stack.translate(goalPos.getX() - renderPosX, -renderPosY, goalPos.getZ() - renderPosZ); // translate
 
-                //TODO: check
                 BeaconRenderer.renderBeaconBeam(
                         stack,
                         ctx.minecraft().renderBuffers().bufferSource(),
-                        TEXTURE_BEACON_BEAM,
+                        BeaconRenderer.BEAM_LOCATION,
                         settings.renderGoalAnimated.value ? partialTicks : 0,
                         1.0F,
                         settings.renderGoalAnimated.value ? ctx.world().getGameTime() : 0,
@@ -294,7 +292,7 @@ private static void drawGoal(@Nullable BufferBuilder bufferBuilder, PoseStack st
                 stack.popPose(); // pop
 
                 if (settings.renderGoalIgnoreDepth.value) {
-//                    RenderSystem.enableDepthTest();
+
                 }
                 return;
             }