Elytra in overworld #4698

babbaj · 2025-04-04T05:24:22Z

Started by @underscore-zi
nether-pathfinder changes have been merged in babbaj/nether-pathfinder#20
Closes #4187

This reverts commit 984c71e.

…ilize height map to save some cycles if player is flying above ground.

thelampgod

wow!

underscore-zi · 2025-04-05T17:54:14Z

I do have a couple minor commits over on https://github.com/underscore-zi/baritone

First is respecting the allowRoof setting when searching for a landing spot. I had left a TODO in for this but hadn't done so yet.

Second is adding Cobblestone and Obsidian to allowed landing blocks. In vanilla the current list is fine but I was using this around 2b's spawn and it had some issues finding landing spots.

ZacSharp · 2025-04-06T01:54:48Z

Can you please wait three days with merging? I'd like to properly read through and test this, but won't be able to do so before April 8.

babbaj · 2025-04-06T02:30:57Z

leijurv never merges my PRs anyways

leijurv · 2025-04-06T04:32:42Z

Can you please wait three days with merging?

say no more, i'll check back next month

ZacSharp

Ok, didn't expect quite as much breakage, but this adds at least two ways to crash the game.

Disabling elytraUseBaritoneCache unconditionally causes an NPE, crashing the game unless this happens inside a command
Disabling elytraAllowAboveRoof while flying above the nether roof and then causing recalculation crashes the game. I didn't even get a crash report, but no segfault either?
Enabling elytraPredictTerrain in the overworld leads to endless recalculation and chat spam. Actually not a crash though.

Some less severe points

The wall of text printed by #elytra unless elytraTermsAccepted is now outdated. It mentions elytra flight only being for the nether (now wrong) and also recommends elytraAutoJump, which has hardly any chance of working in the overworld, and should also mention that terrain prediction is nether-only.
The path is automatically recalculated when elytraNetherSeed changes, elytraAllowThighsSpaces does not have this effect. Not sure whether automatically recalculating is better.

I also really do not like how we are offsetting positions back and forth all across the code. Just look at how many times this went wrong with the existing chunk cache.
Can't we just use exactly one coordinate type (absolute world coordinates) in Baritone and shift to 0 based at the API boundary?
You didn't want to do this in nether-pathfinder itself, but maybe we can wrap the java side of the API to do the shifting?

src/api/java/baritone/api/Settings.java

ZacSharp · 2025-04-09T13:32:26Z

src/main/java/baritone/process/elytra/BlockStateOctreeInterface.java

@@ -39,16 +39,16 @@ public BlockStateOctreeInterface(final NetherPathfinderContext context) {
    }

    public boolean get0(final int x, final int y, final int z) {
-        if ((y | (127 - y)) < 0) {
+        if (y < 0 || y > 383) {


This always checks for the maximum chunk height, is that correct? i.e. does nether-pathfinder always allocate full-size chunks?

ZacSharp · 2025-04-09T13:39:47Z

src/main/java/baritone/process/elytra/NetherPathfinderContext.java

+        if (this.dimension == Level.NETHER) dim = NetherPathfinder.DIMENSION_NETHER;
+        else if (this.dimension == Level.END) dim = NetherPathfinder.DIMENSION_END;
+        else dim = NetherPathfinder.DIMENSION_END;
+        int height = Math.min(world.dimensionType().height(), 384);
+        if (!Baritone.settings().elytraAllowAboveRoof.value && dim == NetherPathfinder.DIMENSION_NETHER) height = Math.min(height, 128);


Ouch. Can you please autoformat your code with whatever formatting the rest of Baritone uses?

using properly formatted braces would make it take up more lines for no benefit

src/main/java/baritone/process/elytra/NetherPathfinderContext.java

ZacSharp · 2025-04-09T13:44:07Z

src/main/java/baritone/process/elytra/NetherPathfinderContext.java

-                boolean isSolid = pair.second() != AIR_BLOCK_STATE;
-                Octree.setBlock(ptr, pos.getX() & 15, pos.getY(), pos.getZ() & 15, isSolid);
-            });
+            // not inserting or deleting from the cache hashmap so we should be fine not being exclusive


Except iirc C++ considers any data race undefined behavior and doing this across an ffi boundary won't make things better.

It's undefined behavior if another thread is writing to the data at the same time we are reading it but that is not the case here.

We are the writing thread here, but since we only have the read lock another thread may do the reading required to trigger undefined behavior.

In case you forgot / didn't see it, there's an Octree.setBlock call in this block. The hashmap reading is hopefully fine, as the comment says.

The pathfinder racing with this would be inconsequential however multiple calls to this to nearby blocks could cause bad data to be written so i will change it to use a write lock. The read executor is still single threaded so there currently isn't a difference anyways.

ZacSharp · 2025-04-09T13:50:53Z

src/main/java/baritone/process/elytra/NetherPathfinderContext.java

-                writeChunkData(chunk, ptr);
+                writeLock.lock();
+                try {
+                    long ptr = NetherPathfinder.allocateAndInsertChunk(this.context, chunk.getPos().x, chunk.getPos().z);


I assume this always returns a completely zeroed chunk?

babbaj · 2025-04-10T04:11:50Z

Disabling elytraUseBaritoneCache unconditionally causes an NPE, crashing the game unless this happens inside a command

fixed

Disabling elytraAllowAboveRoof while flying above the nether roof and then causing recalculation crashes the game. I didn't even get a crash report, but no segfault either?

I don't think this description is accurate. If elytraAllowAboveRoof is off and we put ourself above the roof then there is a crash (nether-pathfinder printing "retard" to stderr and calling std::terminate) but changing that setting while flying has no effect except possibly when it finds a landing spot.

I have not yet fixed this but I will probably fix it by pausing pathfinding until the player goes back below the roof.

Enabling elytraPredictTerrain in the overworld leads to endless recalculation and chat spam. Actually not a crash though.

fixed

The path is automatically recalculated when elytraNetherSeed changes, elytraAllowThighsSpaces does not have this effect. Not sure whether automatically recalculating is better.

fixed to behave the same

ZacSharp · 2025-04-12T20:09:55Z

You want to fix the out-of-bounds crash before merging this or later?

babbaj · 2025-04-12T20:11:33Z

before. i also found another bug last night that's more important.

underscore-zi · 2025-04-12T23:46:49Z

I also really do not like how we are offsetting positions back and forth all across the code. Just look at how many times this went wrong with the existing chunk cache.
Can't we just use exactly one coordinate type (absolute world coordinates) in Baritone and shift to 0 based at the API boundary?

I've added a commit on my branch (underscore-zi@d0c3aea) that pulls all those adjustments into the NetherPathfinderContext methods that make the pathfinder calls along with one Octree usage in BlockStateOctreeInterface.

On a related note, is there a better way for me to share commits? Or would you just prefer I left it all over to Babbaj now since its not my PR?

babbaj · 2025-04-13T00:21:06Z

Just fixed the rest of the known bugs in 75096e1

I've added a commit on my branch (underscore-zi@d0c3aea)

merged

src/main/java/baritone/process/elytra/ElytraBehavior.java

ZacSharp · 2025-04-14T20:37:30Z

Still get a crash by these steps

Stand on the nether roof with some firework rockets and an elytra
Run #settings reset all, #elytraAllowAboveRoof true, #thisway 1000, #elytra
Start flying
Run #elytraAllowAboveRoof false, #elytra reset

ZacSharp · 2025-04-14T20:45:46Z

src/main/java/baritone/process/elytra/ElytraBehavior.java

@@ -1262,6 +1280,7 @@ private static Vec3 step(final Vec3 motion, final Vec3 lookDirection, final floa
        return new Vec3(motionX, motionY, motionZ);
    }

+    // any call to this must be done with the lock held


Can you maybe apply this comment to all methods which require synchronization and specify that the readlock is required?

This is the only function run on the main thread that requires synchronization but i added a comment to solveAngles.

As far as I can tell we have

passable called by simulate and pathFindAroundObstacles simulate called by solvePitch called by the other solvePitch called by solveAngles solveAngles called by onPostTick with synchronisation and by tick (and tick is public) tick called by ElytraProcess.onTick with synchronization on the main thread pathFindAroundObstacles called by PathManager.tick called by onTick0 called by onTick with synchronization on the main thread

At least tick needing synchronization should be documented.

src/main/java/baritone/process/elytra/BlockStateOctreeInterface.java

ZacSharp · 2025-04-14T20:54:05Z

On a related note, is there a better way for me to share commits? Or would you just prefer I left it all over to Babbaj now since its not my PR?

You could open pull requests against babbaj's pull request branch, but I'm not sure whether that's better than a writing a comment.

babbaj · 2025-04-15T07:04:23Z

Still get a crash by these steps

fixed

ZacSharp · 2025-04-15T13:18:06Z

Still get a crash by these steps

fixed

Replace #elytra reset with changing elytraNetherSeed/elytraPredictTerrain/elytraAllowTightSpaces and it crashes once again.

babbaj · 2025-04-15T19:07:17Z

fixed again

ZacSharp

I'm out of crashes now. The only thing I managed to find is an "Unhandled exception" error message when you change to an invalid goal mid-flight, but that's not new. (e.g. #goal ~).

leijurv · 2025-04-22T06:23:03Z

I will merge this..... on one condition........

When you #elytra to a goal in the overworld that is at least some distance away (configurable setting, defaults to, let's say 1000 blocks), it should fly upwards (if it cannot fly upwards it'll go towards the goal of course). Once it gets above y=320, it will have a single target point that is simply the goal (ignoring the Y of the goal). I think this will work fine in the code because raytraces in minecraft have a maximum number of blocks they visit so it won't be too laggy? If it is laggy just add partial points at fractions along the way. Then once it is near the goal it dips back down below 320 and does landing or whatever at the goal

I think this would be a compromise that would allow it to fly through interesting overworld terrain like 2b2t spawn, while still going straight any-angle diagonal towards the goal (rather than the straight + 45° thing that I just think is low quality).

babbaj · 2025-04-22T07:33:54Z

It is currently not possible to fly above y 320 without increasing the height in nether-pathfinder even more. That should be an easy change.

kittenvr · 2025-04-23T20:21:51Z

This is amazing

underscore-zi and others added 13 commits March 15, 2025 03:32

Add initial support for overworld/end flight

75a3acd

update to nether-pathfinder api/concurrency changes

dd2240a

Make usage of the Baritone cache optional for elytra flight

9d0a4cb

Set a better default Y for elytra GoalXZ

984c71e

Make sure player is in bounds before attempting elytra pathfinding

319aa58

Allow landing on bedrock (necessary for nether roof)

18a6899

Revert "Set a better default Y for elytra GoalXZ"

662ba65

This reverts commit 984c71e.

GoalXZ y-level will consider if player is above nether roof

c9aa9f7

Rework landing to be safed when descending from high y-levels, and ut…

b0ba8d3

…ilize height map to save some cycles if player is flying above ground.

Check negative y landing spots too

1a6c43e

Merge branch 'cabaletta:1.19.4' into 1.19.4

2004a1d

dynamically change destination y if the roof gets in the way

cf3260c

1.6

2290801

babbaj changed the title ~~Nether elytra update~~ Elytra in overworld Apr 4, 2025

memset if no air also cave air is real

3fb41ea

babbaj marked this pull request as ready for review April 4, 2025 07:29

thelampgod approved these changes Apr 4, 2025

View reviewed changes

ZacSharp mentioned this pull request Apr 4, 2025

Add support for auto-flight with Elytras in the overworld and the End. #4693

Closed

2 tasks

babbaj requested a review from leijurv April 5, 2025 03:59

babbaj and others added 3 commits April 5, 2025 00:05

custom allocator by default :^)

c7b76bc

Respect allowAboveRoof roof setting when looking for safe landing spots

094b3ef

Allow landing on cobblestone and obsidian

1ea67c2

ZacSharp requested changes Apr 9, 2025

View reviewed changes

babbaj added 2 commits April 10, 2025 00:12

elytra fixes

7feaa51

hold write lock in queueBlockUpdate

f3e6116

Keep zero-based coordinates to within pathfinder code

d0c3aea

babbaj added 2 commits April 12, 2025 20:15

fix crashes

75096e1

Merge remote-tracking branch 'origin/1.19.4' into nether-elytra-update

42e1a7a

babbaj added 2 commits April 12, 2025 20:24

final

470ef10

rename elytraUseBaritoneCache

0912069

ZacSharp reviewed Apr 13, 2025

View reviewed changes

src/main/java/baritone/process/elytra/ElytraBehavior.java Outdated Show resolved Hide resolved

oops

20c1631

ZacSharp reviewed Apr 14, 2025

View reviewed changes

babbaj added 2 commits April 14, 2025 23:46

fix #elytra reset bypassing y checks

68dc110

i forgor to commit this

04813a8

fixes

3d5b744

ZacSharp approved these changes Apr 16, 2025

View reviewed changes

zhou20120904 mentioned this pull request Apr 19, 2025

Add support for auto-flight with Elytras in the overworld and the End. #4187

Open

2 tasks

fix exception when setting out of bounds goal while elytra flying

e545294

fix deadlock

5624d4a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Elytra in overworld #4698

Elytra in overworld #4698

babbaj commented Apr 4, 2025 •

edited

Loading

thelampgod left a comment

underscore-zi commented Apr 5, 2025 •

edited

Loading

ZacSharp commented Apr 6, 2025

babbaj commented Apr 6, 2025

leijurv commented Apr 6, 2025

ZacSharp left a comment

ZacSharp Apr 9, 2025

babbaj Apr 10, 2025

ZacSharp Apr 9, 2025

babbaj Apr 10, 2025

ZacSharp Apr 9, 2025

babbaj Apr 10, 2025

ZacSharp Apr 10, 2025

ZacSharp Apr 10, 2025

babbaj Apr 11, 2025

ZacSharp Apr 9, 2025

babbaj Apr 10, 2025

babbaj commented Apr 10, 2025 •

edited

Loading

ZacSharp commented Apr 12, 2025

babbaj commented Apr 12, 2025

underscore-zi commented Apr 12, 2025 •

edited

Loading

babbaj commented Apr 13, 2025

ZacSharp commented Apr 14, 2025

ZacSharp Apr 14, 2025

babbaj Apr 15, 2025

ZacSharp Apr 15, 2025

ZacSharp commented Apr 14, 2025

babbaj commented Apr 15, 2025

ZacSharp commented Apr 15, 2025 •

edited

Loading

babbaj commented Apr 15, 2025

ZacSharp left a comment

leijurv commented Apr 22, 2025

babbaj commented Apr 22, 2025

kittenvr commented Apr 23, 2025

Elytra in overworld #4698

Are you sure you want to change the base?

Elytra in overworld #4698

Conversation

babbaj commented Apr 4, 2025 • edited Loading

thelampgod left a comment

Choose a reason for hiding this comment

underscore-zi commented Apr 5, 2025 • edited Loading

ZacSharp commented Apr 6, 2025

babbaj commented Apr 6, 2025

leijurv commented Apr 6, 2025

ZacSharp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

babbaj commented Apr 10, 2025 • edited Loading

ZacSharp commented Apr 12, 2025

babbaj commented Apr 12, 2025

underscore-zi commented Apr 12, 2025 • edited Loading

babbaj commented Apr 13, 2025

ZacSharp commented Apr 14, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ZacSharp commented Apr 14, 2025

babbaj commented Apr 15, 2025

ZacSharp commented Apr 15, 2025 • edited Loading

babbaj commented Apr 15, 2025

ZacSharp left a comment

Choose a reason for hiding this comment

leijurv commented Apr 22, 2025

babbaj commented Apr 22, 2025

kittenvr commented Apr 23, 2025

babbaj commented Apr 4, 2025 •

edited

Loading

underscore-zi commented Apr 5, 2025 •

edited

Loading

babbaj commented Apr 10, 2025 •

edited

Loading

underscore-zi commented Apr 12, 2025 •

edited

Loading

ZacSharp commented Apr 15, 2025 •

edited

Loading