Remove unused dependencies #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierjulio
force-pushed
the
deps-clean-up
branch
from
d6bd488 to
95177ea
Compare
|
@cakeinpanic as mentioned in #49 this is a follow up to help reduce the number of dependencies and those reduce the lock file size. CI is green with this change and tests pass locally as well. |
javierjulio
force-pushed
the
deps-clean-up
branch
from
95177ea to
54c399a
Compare
|
Hi, I don't see the reason to remove |
javierjulio
force-pushed
the
deps-clean-up
branch
from
54c399a to
f7629ae
Compare
No need to declare npm in engines since npm is included with node. This also matches what the template repo does: https://github.com/actions/typescript-action/blob/main/package.json
javierjulio
force-pushed
the
deps-clean-up
branch
from
f7629ae to
27b1478
Compare
|
@cakeinpanic no worries, I dropped that commit so it remains in place. This is now ready. |
cakeinpanic
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As promised from #49 this is a follow up to remove unused dependencies as I noticed some while working on that PR.
I tried addressing some security updates but any seem to break CI, although running tests locally is successful. Addressing the many outdated dependencies should be done individually. I won't be able to contribute there as I'm not familiar with Typescript and Jest which have the most.