Skip to content

Coerce model dimension dtypes to numeric #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

brynpickering
Copy link
Member

Fixes #567

Summary of changes in this pull request:

  • Always try to convert data dimensions to numeric and keep any successful attempts.
  • Add some tests.
  • Add mention of this in the docs.

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

@brynpickering brynpickering changed the title Coerce model data dtypes to numeric Coerce model dimension dtypes to numeric Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.86%. Comparing base (872978d) to head (a099c5b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #575      +/-   ##
==========================================
+ Coverage   95.85%   95.86%   +0.01%     
==========================================
  Files          24       24              
  Lines        3619     3629      +10     
  Branches      788      724      -64     
==========================================
+ Hits         3469     3479      +10     
  Misses         86       86              
  Partials       64       64              
Files Coverage Δ
src/calliope/preprocess/model_data.py 100.00% <100.00%> (ø)

@brynpickering brynpickering merged commit 41f9060 into main Feb 29, 2024
@brynpickering brynpickering deleted the feature-dim-numeric-dtype branch February 29, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot define numeric index items when loading tabular data
2 participants