Skip to content

Clean up warning capture #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 1, 2024
Merged

Clean up warning capture #577

merged 5 commits into from
Mar 1, 2024

Conversation

brynpickering
Copy link
Member

Fixes reduced coverage reported in #574 (I hope).

It turns out that the warning formatter wasn't being called, maybe some change in Python warnings (but couldn't see anything in the changelog). I've also updated how we capture warnings with our logging module, so it actually pipes warnings to the logger.

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Base automatically changed from update-dependencies to main February 29, 2024 11:25
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 95.83%. Comparing base (872978d) to head (e8ec00b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
- Coverage   95.85%   95.83%   -0.02%     
==========================================
  Files          24       24              
  Lines        3619     3628       +9     
  Branches      788      724      -64     
==========================================
+ Hits         3469     3477       +8     
  Misses         86       86              
- Partials       64       65       +1     
Files Coverage Δ
src/calliope/model.py 93.62% <100.00%> (-0.03%) ⬇️
src/calliope/preprocess/load.py 92.20% <ø> (ø)
src/calliope/util/logging.py 94.33% <100.00%> (+0.46%) ⬆️
src/calliope/exceptions.py 97.14% <66.66%> (-2.86%) ⬇️

sjpfenninger
sjpfenninger previously approved these changes Feb 29, 2024
@brynpickering brynpickering merged commit 6fd9084 into main Mar 1, 2024
@brynpickering brynpickering deleted the update-logging-warns branch March 1, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants