-
Notifications
You must be signed in to change notification settings - Fork 97
Attach model_creation and solve_complete timestamps to model data attrs #586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
+ Coverage 95.85% 95.92% +0.06%
==========================================
Files 24 24
Lines 3619 3628 +9
Branches 788 723 -65
==========================================
+ Hits 3469 3480 +11
+ Misses 86 84 -2
Partials 64 64
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have come across an issue in previous runs that this should solve. If there is any lag between calling model.build()
and model.solve()
, you get an artificially extended solve time. The logger should also capture when model.build()
and model.run()
were called. Then build/solve time is the difference between finish and start times.
Since
|
Sorry, yeah, mistype on my part. Those logging timestamps sound good. |
Now have five timestamps (in order of occurrence):
|
Fixes #583
Summary of changes in this pull request:
Reviewer checklist: