Skip to content

Update PR template #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Update PR template #589

merged 2 commits into from
Apr 16, 2024

Conversation

brynpickering
Copy link
Member

Current template doesn't trigger automated issue linking. This should fix that.

Reviewer checklist:

  • Test(s) added to cover contribution
  • Documentation updated
  • Changelog updated
  • Coverage maintained or improved

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (872978d) to head (2a8f744).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #589      +/-   ##
==========================================
- Coverage   95.85%   95.83%   -0.02%     
==========================================
  Files          24       24              
  Lines        3619     3628       +9     
  Branches      788      724      -64     
==========================================
+ Hits         3469     3477       +8     
  Misses         86       86              
- Partials       64       65       +1     

@sjpfenninger
Copy link
Member

What's the issue this solves?

Co-authored-by: Stefan Pfenninger <stefan@pfenninger.org>
@brynpickering
Copy link
Member Author

What's the issue this solves?

Previously it was Fixes issue(s) # but this will not link a PR to an issue (and then automatically close that issue when the PR is merged). Now it is simply Fixes # which does link the issue automatically.

@sjpfenninger sjpfenninger merged commit 6b4bd86 into main Apr 16, 2024
12 of 13 checks passed
@sjpfenninger sjpfenninger deleted the update-pr-template branch April 16, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants