Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact and TermsOfService fields should be removed from info object #143

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

bigludo7
Copy link
Collaborator

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Removed Contact and TermsOfService fields from info object

Which issue(s) this PR fixes:

Fixes #141

Special notes for reviewers:

version back to wip

Changelog input

 release-note
-Removed Contact and TermsOfService fields from info object 

Additional documentation

This section can be blank.

docs

Contact and TermsOfService fields should be removed from info object
@rartych
Copy link
Contributor

rartych commented Aug 21, 2024

I guess, the same fix is needed in sim-swap-subscriptions.yaml

Removed Contact and TermsOfService fields from info object
@bigludo7
Copy link
Collaborator Author

Hopefully you're on duty @rartych :)
Thanks !!!!

@hdamker
Copy link
Collaborator

hdamker commented Aug 21, 2024

If you don't plan to release sim-swap-subscriptions.yaml here anymore, you don't need to touch it. It wouldn't harm either as you will delete the wip version before the release (I'm referring here to the discussion in #142).

For the transfer to another repository I would only pick a released version to have a change history without a gap (I guess we need to describe this process).

Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bigludo7 bigludo7 merged commit df156ac into camaraproject:main Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contact and TermsOfService fields should be removed from info object
4 participants