Skip to content

ci: Introduce PyPi Publisher workflow #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 18, 2025
Merged

Conversation

kellervater
Copy link
Contributor

@kellervater kellervater commented Apr 17, 2025

As requested in this discussion this PR adds a PyPi publisher workflow to the repository.

  • The workflow has been added as Trusted Publisher in PyPi so we don't need to handle any access tokens.
  • The setup.cfg has been merged into the new pyproject.toml
  • Currently the pubishing workflow also runs on push in this branch as long as we test.

Related issue: https://github.com/camunda/team-infrastructure/issues/801

@CLAassistant
Copy link

CLAassistant commented Apr 17, 2025

CLA assistant check
All committers have signed the CLA.

This shall ensure no one messes with the code between releases
@kellervater kellervater requested a review from Copilot April 17, 2025 14:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • setup.cfg: Language not supported
Comments suppressed due to low confidence (2)

pyproject.toml:29

  • The license-files glob pattern appears unusual; consider verifying if 'LICEN[CS]E*' is the intended pattern or if it should be 'LICENSE*'.
license-files = ["LICEN[CS]E*"]

.github/workflows/publish.yml:2

  • The PR description mentions that the publishing workflow runs on push for testing, but the diff only triggers on release (published). If push events are desired for testing, consider updating the trigger accordingly.
on:

Copy link
Contributor

@danbailo danbailo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job! Thanks!!

@kellervater kellervater merged commit 983d321 into master Apr 18, 2025
8 checks passed
@yogeshrnaik
Copy link
Collaborator

@kellervater Nice work! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants