Skip to content

Commit 1d5e239

Browse files
tasso94joaquinfelici
authored andcommitted
chore(engine): bump spring dependency to version 6
related to #4869
1 parent 12d4289 commit 1d5e239

File tree

7 files changed

+27
-102
lines changed

7 files changed

+27
-102
lines changed

engine/pom.xml

+8-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
<dependency>
2727
<groupId>org.springframework</groupId>
2828
<artifactId>spring-framework-bom</artifactId>
29-
<version>${version.spring.framework}</version>
29+
<version>${version.spring.framework6}</version>
3030
<type>pom</type>
3131
<scope>import</scope>
3232
</dependency>
@@ -333,6 +333,13 @@
333333
<version>${project.version}</version>
334334
<scope>test</scope>
335335
</dependency>
336+
337+
<dependency>
338+
<groupId>com.github.h-thurow</groupId>
339+
<artifactId>simple-jndi</artifactId>
340+
<version>0.24.0</version>
341+
<scope>test</scope>
342+
</dependency>
336343
</dependencies>
337344

338345

engine/src/test/java/org/camunda/bpm/container/impl/jmx/deployment/BpmPlatformXmlLocationTest.java

+15-6
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@
3535
import java.net.URLDecoder;
3636

3737
import org.camunda.bpm.container.impl.tomcat.deployment.TomcatParseBpmPlatformXmlStep;
38-
import org.junit.Rule;
38+
import org.junit.After;
39+
import org.junit.Before;
3940
import org.junit.Test;
40-
import org.springframework.mock.jndi.SimpleNamingContext;
4141

4242
/**
4343
* Checks the correct retrieval of bpm-platform.xml file through JNDI,
@@ -63,8 +63,19 @@ public class BpmPlatformXmlLocationTest {
6363
private static final String BPM_PLATFORM_XML_LOCATION_URL_HTTP_PROTOCOL = "http://localhost:8080/camunda/" + BPM_PLATFORM_XML_FILE;
6464
private static final String BPM_PLATFORM_XML_LOCATION_URL_HTTPS_PROTOCOL = "https://localhost:8080/camunda/" + BPM_PLATFORM_XML_FILE;
6565

66-
@Rule
67-
public MockInitialContextRule initialContextRule = new MockInitialContextRule(new SimpleNamingContext());
66+
protected Context context;
67+
68+
@Before
69+
public void setUp() throws NamingException {
70+
context = new InitialContext();
71+
}
72+
73+
@After
74+
public void close() throws NamingException {
75+
if (context != null) {
76+
context.close();
77+
}
78+
}
6879

6980
@Test
7081
public void checkValidBpmPlatformXmlResourceLocationForUrl() throws NamingException, MalformedURLException {
@@ -121,7 +132,6 @@ public void checkValidBpmPlatformXmlResourceLocation() throws NamingException, M
121132

122133
@Test
123134
public void getBpmPlatformXmlLocationFromJndi() throws NamingException, MalformedURLException {
124-
Context context = new InitialContext();
125135
context.bind("java:comp/env/" + BPM_PLATFORM_XML_LOCATION, BPM_PLATFORM_XML_FILE_ABSOLUTE_LOCATION);
126136

127137
URL url = new TomcatParseBpmPlatformXmlStep().lookupBpmPlatformXmlLocationFromJndi();
@@ -184,7 +194,6 @@ public void getBpmPlatformXmlFromCatalinaConfDirectory() throws MalformedURLExce
184194

185195
@Test
186196
public void lookupBpmPlatformXml() throws NamingException, MalformedURLException {
187-
Context context = new InitialContext();
188197
context.bind("java:comp/env/" + BPM_PLATFORM_XML_LOCATION, BPM_PLATFORM_XML_FILE_ABSOLUTE_LOCATION);
189198

190199
URL url = new TomcatParseBpmPlatformXmlStep().lookupBpmPlatformXml();

engine/src/test/java/org/camunda/bpm/container/impl/jmx/deployment/MockInitialContextFactory.java

-42
This file was deleted.

engine/src/test/java/org/camunda/bpm/container/impl/jmx/deployment/MockInitialContextRule.java

-50
This file was deleted.

engine/src/test/java/org/camunda/bpm/engine/test/api/history/HistoryCleanupOnEngineBootstrapTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ public void testBatchWindowXmlConfigParsingException() throws ParseException {
184184
.createProcessEngineConfigurationFromResource("org/camunda/bpm/engine/test/history/history-cleanup-batch-window-map-wrong-values.camunda.cfg.xml")
185185
.buildProcessEngine())
186186
.isInstanceOf(Exception.class)
187-
.hasMessageContaining("startTime");
187+
.hasMessageContaining("Error creating bean with name 'processEngineConfiguration'");
188188
}
189189

190190
@Test
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
java.naming.factory.initial=org.osjava.sj.SimpleContextFactory
2+
org.osjava.sj.jndi.shared=true

webapps/assembly/src/main/java/org/camunda/bpm/webapp/impl/security/filter/PathFilterRule.java

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,9 @@
2222
import org.camunda.bpm.webapp.impl.security.auth.Authentication;
2323
import org.camunda.bpm.webapp.impl.security.filter.RequestMatcher.Match;
2424
import org.camunda.bpm.webapp.impl.security.filter.util.FilterRules;
25-
import org.springframework.util.PathMatcher;
2625

2726
/**
28-
* <p>A {@link SecurityFilterRule} that deleagates to a set of {@link PathMatcher}s</p>
27+
* <p>A {@link SecurityFilterRule} that delegates to a set of path matchers</p>
2928
*
3029
* <p>How this thing works:
3130
* <ul>

0 commit comments

Comments
 (0)