Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camunda-webapp-webjar 7.22.0 causes IllegalArgumentException on org.springframework.web.servlet.resource.ResourceHttpRequestHandler v6.2.0-RC3 #4753

Closed
1 task
milazzo-g opened this issue Oct 31, 2024 · 6 comments
Assignees
Labels
group:closed-as-inactive DRI: Yana group:requested-info DRI: Yana group:stale DRI: Yana type:bug Issues that describe a user-facing bug in the project.

Comments

@milazzo-g
Copy link

milazzo-g commented Oct 31, 2024

Environment

any

Description

camunda-webapp-webjar 7.22.0 causes IllegalArgumentException on org.springframework.web.servlet.resource.ResourceHttpRequestHandler v6.2.0-RC3

Steps to reproduce

create an application with spring boot 6.2.0-RC3 and camunda-webapp-webjar 7.22.0 included by camunda-bpm-spring-boot-starter-root 7.22.0

Observed Behavior

During context loading the ResourceHttpRequestHandler class scans all possible paths and if these do not end with "/" an IllegalArgumentException type exception is thrown with message "Resource location does not end with slash: …" (see ResourceHttpRequestHandler@283 the call to ResourceHandlerUtils::assertLocationPath). The path provided by your library is "classpath:/META-INF/resources/webjars/camunda" which as you can see does not contain the final "/". Could you fix it in a next minor? This is critical as the current version of camunda-webapp-webjar (7.22.0) is unusable with spring-boot 6.2.0-RC3.

Expected behavior (Required on creation)

All path from library should ends with "/"

Root Cause (Required on prioritization)

Path from library not ends with "/"

Solution Ideas

Add "/" on all path

Hints

Links

issue on spring-boot repo

1

2

STACKTRACE.txt

Breakdown

Pull Requests

Preview Give feedback
No tasks being tracked yet.

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@milazzo-g milazzo-g added the type:bug Issues that describe a user-facing bug in the project. label Oct 31, 2024
@venetrius venetrius self-assigned this Nov 4, 2024
@venetrius
Copy link
Member

Hi @milazzo-g,
Thanks for reporting this issue. I will look into it and get back to you.

@tasso94 tasso94 mentioned this issue Nov 18, 2024
1 task
@venetrius
Copy link
Member

Hi @milazzo-g,
Camunda 7.22.0 supports SpringBoot 3.3 which is uses Spring Framework 6.1.x
https://repo1.maven.org/maven2/org/springframework/boot/spring-boot/3.4.0/spring-boot-3.4.0.pom

Support for Spring Boot 3.4 is planned to be added for the Camunda 7.23. release. You can see this in the Camunda Platform Announcements

Spring Boot 3.4 supports Spring Framework 6.2.x:
https://repo1.maven.org/maven2/org/springframework/boot/spring-boot/3.4.0/spring-boot-3.4.0.pom

@venetrius venetrius added the group:stale DRI: Yana label Nov 28, 2024
@venetrius venetrius added group:requested-info DRI: Yana and removed group:stale DRI: Yana labels Dec 19, 2024
@github-actions github-actions bot added the group:stale DRI: Yana label Dec 20, 2024
Copy link

Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information to re-open the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2024
@jpbassinello
Copy link

I don't get any errors on startup but still getting a warn from ResourceHandlerUtils

2025-02-21T14:14:08.605Z  WARN 28703 --- [cards] [           main] o.s.w.s.resource.ResourceHandlerUtils    : Appended trailing slash to static resource location: classpath:/META-INF/resources/webjars/camunda/

I tried to manually adjust properties by adding to my application.yaml:

webapp:
  webjar-classpath: /META-INF/resources/webjars/camunda/
  security-config-file: securityFilterRules.json

but then I get a 404 when accessing the webapp

java.io.FileNotFoundException: class path resource [META-INF/resources/webjars/camunda//app/cockpit/index.html] cannot be opened because it does not exist

@tasso94
Copy link
Member

tasso94 commented Mar 11, 2025

Hi @venetrius, can you check @jpbassinello latest message?

@venetrius venetrius reopened this Mar 11, 2025
@venetrius venetrius closed this as not planned Won't fix, can't repro, duplicate, stale Mar 11, 2025
@venetrius
Copy link
Member

Hi @jpbassinello,
Do you have the same setup as described in the issue description?
Would you able to check if you have the same issue when building you app with the latest alpha release ? If yes, I would advise you to open a new bug report.

Thanks,
Gergely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
group:closed-as-inactive DRI: Yana group:requested-info DRI: Yana group:stale DRI: Yana type:bug Issues that describe a user-facing bug in the project.
Projects
None yet
Development

No branches or pull requests

4 participants