Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump engine dependency to Spring 6 #4869

Closed
9 tasks done
tasso94 opened this issue Jan 2, 2025 · 5 comments
Closed
9 tasks done

Bump engine dependency to Spring 6 #4869

tasso94 opened this issue Jan 2, 2025 · 5 comments
Assignees
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.23.0-alpha4 version:7.23.0

Comments

@tasso94
Copy link
Member

tasso94 commented Jan 2, 2025

Context

The engine currently has a dependency on Spring 5 to allow configuring the engine via an XML file.

Acceptance Criteria (Required on creation)

The dependency is updated to Spring 6.

Hints

Links

Breakdown

Pull Requests

Preview Give feedback
  1. bot:java-dependency-check ci:all-as
    joaquinfelici
  2. joaquinfelici
  3. ci:all-as ci:all-db ci:default-build ci:e2e ci:jdk ci:migration ci:rest-api ci:rolling-update ci:spring-boot ci:webapp-integration
    joaquinfelici
  4. joaquinfelici
  5. joaquinfelici
  6. ci:jdk ci:skipTests
    yanavasileva
  7. ci:no-build ci:skipTests ci:sqlserver ci:wildfly
    yanavasileva

Dev2QA handover

  • Does this ticket need a QA test and the testing goals are not clear from the description? Add a Dev2QA handover comment
@tasso94 tasso94 added type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.23.0 labels Jan 2, 2025
@tasso94 tasso94 self-assigned this Jan 2, 2025
tasso94 added a commit that referenced this issue Jan 2, 2025
tasso94 added a commit that referenced this issue Jan 3, 2025
@tasso94 tasso94 assigned joaquinfelici and unassigned tasso94 Jan 20, 2025
joaquinfelici added a commit to camunda/camunda-docs-manual that referenced this issue Jan 20, 2025
@mboskamp
Copy link
Member

Hey @joaquinfelici, can you share some information/documentation about the changes in those PRs? It's hard to understand why they are necessary.

@joaquinfelici
Copy link
Contributor

Hey @mboskamp , discussed with Tassilo who took care of most of this fix. Spring 5 is EOL, so we're changing the default spring version to 6 for the engine. Spring 5 is still supported but must be explicitly overridden. Websphere Liberty and other impacted distros continue using spring 5, hence the exclusions. The JNDI changes are due to a change in Spring, now the testing library for JNDI was removed, and they propose to add simple-jndi (more info here).

@mboskamp
Copy link
Member

I left a few comments/questions in the PRs.

@joaquinfelici
Copy link
Contributor

Re-assigning reviewer to @venetrius to get this merged soon.

@yanavasileva yanavasileva added the scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI label Mar 3, 2025
joaquinfelici added a commit that referenced this issue Mar 4, 2025
* chore(engine): bump spring dependency to version 6

related to #4869
@yanavasileva
Copy link
Member

@joaquinfelici, the test release job is failing after the merge.
https://release.cambpm.camunda.cloud/job/7.23/job/7.23-TEST-RELEASE-create-camunda-bpm-version-tags/157/

01:54:23     [java] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-release-plugin:3.0.1:prepare (default-cli) on project camunda-bpm-platform-release-root: Can't release project due to non released dependencies :
01:54:23     [java] [ERROR]     org.camunda.bpm.qa:camunda-qa-integration-tests-engine-jakarta:test-jar:tests:7.23.0-SNAPSHOT:test
01:54:23     [java] [ERROR] in project 'Camunda Platform EE - QA Integration Tests - Engine Jakarta' (org.camunda.bpm.qa:camunda-qa-integration-tests-ee-jakarta:jar:7.23.0-SNAPSHOT)

integration-tests-engine-jakarta module should be included in the distro maven profile:
https://github.com/camunda/camunda-bpm-platform/blob/master/qa/pom.xml#L76-L87
previously it's automatically included since the job is using JDK 17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:core-api Changes to the core API: engine, dmn-engine, feel-engine, REST API, OpenAPI type:task Issues that are a change to the project that is neither a feature nor a bug fix. version:7.23.0-alpha4 version:7.23.0
Projects
None yet
Development

No branches or pull requests

5 participants