Implement filteration by rootProcessInstanceId for Process Instances and History Process instances endpoints #2582 #4925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Hello @prakashpalanisamy ,
Thanks for the contribution! The changes look really good overall, I left one comment regarding the formatting changes in the Execution.xml file.
Before I continue my review, I will duplicate your PR to run our CI on it to make sure no regressions were introduced. In the meantime, did you test this manually?
Thanks you.
engine/src/main/resources/org/camunda/bpm/engine/impl/mapping/entity/Execution.xml
Show resolved
Hide resolved
joaquinfelici
requested changes
Feb 21, 2025
|
@joaquinfelici Thank you for spending time on this. Please give me some time to look into your inputs. And yes I did manual tests as part of the code change as well. |
kayhern
force-pushed
the
feature/git-issue-2582-filter-pid-by-rootProcessInstanceId
branch
from
d89006d to
96c55fd
Compare
|
@joaquinfelici I made the changes and re-requested review. Please review when you get time. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the /process-instance & history/process-instance APIs, Have implemented the root-process-instance filters to get the Process instances related to the provided root-process-instance.
Git Issue: #2582