Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(spring-boot-webapp): resolve favicon path #4967

Merged
merged 1 commit into from
Mar 11, 2025
Merged

fix(spring-boot-webapp): resolve favicon path #4967

merged 1 commit into from
Mar 11, 2025

Conversation

venetrius
Copy link
Member

related to: /issues/4930

@venetrius venetrius added the ci:spring-boot Runs the integration tests for the Spring Boot starter. label Mar 4, 2025
@venetrius venetrius self-assigned this Mar 4, 2025
@venetrius venetrius mentioned this pull request Mar 4, 2025
Open
1 task
@venetrius venetrius force-pushed the 4930-Favicon-spring-boot branch from 220369d to 63e2863 Compare March 4, 2025 14:07
@venetrius venetrius added bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 Backports PR to maintenance branch 7.22. labels Mar 4, 2025
@venetrius venetrius requested a review from mboskamp March 7, 2025 07:24
mboskamp
mboskamp approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@mboskamp mboskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. You added tests for custom paths as well, great!
🔧 One nice-to-have test would be to check that the log output does not contain the warn log anymore. We have a JUnit rule for that. But I don't think it's super necessary here.

@venetrius
Copy link
Member Author

Thanks @mboskamp,
I spent some time looking into the test.
In the and I opted to not add a new test for now. It was verified manually that the warning message is not present.

@venetrius venetrius merged commit dde22ef into master Mar 11, 2025
9 checks passed
@venetrius venetrius deleted the 4930-Favicon-spring-boot branch March 11, 2025 12:24
@ap-development-workflow
Copy link

Successfully created backport PR for 7.21:

  • camunda/camunda-bpm-platform-maintenance#1369

@ap-development-workflow
Copy link

Successfully created backport PR for 7.22:

  • camunda/camunda-bpm-platform-maintenance#1370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboskamp mboskamp mboskamp approved these changes

Assignees

@venetrius venetrius

Labels
bot:backport:7.21 Backports PR to maintenance branch 7.21. bot:backport:7.22 Backports PR to maintenance branch 7.22. ci:spring-boot Runs the integration tests for the Spring Boot starter.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venetrius @mboskamp