Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): fix wildfly 26 stage to use JDK 11 #4978

Merged
merged 6 commits into from
Mar 7, 2025
Merged

chore(ci): fix wildfly 26 stage to use JDK 11 #4978

merged 6 commits into from
Mar 7, 2025

Conversation

yanavasileva
Copy link
Member

@yanavasileva yanavasileva commented Mar 7, 2025 •
edited
Loading

fixes hanging stage due to wrong JDK.
#4869

@yanavasileva yanavasileva added the ci:wildfly Runs the builds for the Wildfly application server. label Mar 7, 2025
@yanavasileva yanavasileva self-assigned this Mar 7, 2025
@yanavasileva yanavasileva added the ci:skipTests Skips tests execution in Assembly and Distro-ee stages. label Mar 7, 2025
@yanavasileva yanavasileva requested a review from mboskamp March 7, 2025 08:35
@yanavasileva yanavasileva mentioned this pull request Mar 7, 2025
Closed
1 task
mboskamp
mboskamp approved these changes Mar 7, 2025
View reviewed changes
Copy link
Member

@mboskamp mboskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good, CI stage already ran successfully on this PR.

@yanavasileva yanavasileva added ci:sqlserver Runs the builds for the MS SQL Server database. and removed ci:wildfly Runs the builds for the Wildfly application server. labels Mar 7, 2025
@yanavasileva yanavasileva requested a review from mboskamp March 7, 2025 13:10
@yanavasileva
Copy link
Member Author

yanavasileva commented Mar 7, 2025 •
edited
Loading

@mboskamp, I found more failures on master, please check latest changes and CI execution.

engine-IT-wildfly26-servlet, instance-migration-azure-sql-db-150

@mboskamp mboskamp added the ci:wildfly Runs the builds for the Wildfly application server. label Mar 7, 2025
mboskamp
mboskamp reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@mboskamp mboskamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍
I think we should run the CI with the wildfly label because some of the changed stages require it and did not run yet. I added it and retriggered the relevant CI.

@yanavasileva
Copy link
Member Author

yanavasileva commented Mar 7, 2025 •
edited
Loading

Changes with WildFly label already ran successfully here: https://ci-pipeline.cambpm.camunda.cloud/job/7.23/job/cambpm-ce/job/cambpm-main/job/PR-4978/3/
Sidetrack passed successfully here: https://ci-pipeline.cambpm.camunda.cloud/job/7.23/job/cambpm-ce/job/cambpm-sidetrack/job/PR-4978/1/

@yanavasileva
Copy link
Member Author

Prepare for merge, revert test labels:

@yanavasileva
Revert "to revert"
4949cb2 
This reverts commit 22cbbc3.
@yanavasileva yanavasileva added the ci:no-build Prevents any CI stage from running. label Mar 7, 2025
@yanavasileva yanavasileva merged commit 4424976 into master Mar 7, 2025
3 checks passed
@yanavasileva yanavasileva deleted the 4869-fix-wildfly26-stage branch March 7, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboskamp mboskamp mboskamp approved these changes

Assignees

@yanavasileva yanavasileva

Labels
ci:no-build Prevents any CI stage from running. ci:skipTests Skips tests execution in Assembly and Distro-ee stages. ci:sqlserver Runs the builds for the MS SQL Server database. ci:wildfly Runs the builds for the Wildfly application server.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yanavasileva @mboskamp