Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(engine): bump spring dependency to version 6 #4952

Merged
merged 12 commits into from
Mar 4, 2025

Conversation

joaquinfelici
Copy link
Contributor

@joaquinfelici joaquinfelici commented Feb 19, 2025

Related to #4869

Duplicate of #4862 (reverted) created for CI fixes

@joaquinfelici joaquinfelici self-assigned this Feb 19, 2025
@joaquinfelici joaquinfelici added ci:all-as Runs the builds for all application servers. ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:jdk Runs the builds for all supported Java versions. ci:migration Runs the process instance migration builds. ci:rolling-update Runs the rolling update builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:spring-boot Runs the integration tests for the Spring Boot starter. ci:webapp-integration Runs the webapp integration builds. labels Feb 19, 2025
@joaquinfelici
Copy link
Contributor Author

Hints for review

The spring 6 upgrade hasn't changed since the original reverted PR. All new changes are related to CI or QA modules.

CI / QA

  • Spring 6 is no longer compatible with Java 11.
  • When we can, we're now building with Java 17 by default.
  • Some jobs still need to use Java 11. In these cases, we're either not executing spring 6 code or we override the Spring version to keep using Spring 5 (for example jdk11 or instance migration jobs).
  • When using JDK 17, some modules needed to be opened as they are no longer by default.

@joaquinfelici joaquinfelici requested review from venetrius and yanavasileva and removed request for venetrius February 26, 2025 10:11
@yanavasileva yanavasileva added the ci:e2e Runs the frontend end-to-end tests. label Feb 27, 2025
Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Many of the QA DB tests stages are not run by default in the PR even with labels. I expect failures for migration, large, since the JDK 11 there.

📓 General note, as long as we have JDK 11 daily stages, we are fine to move most of the stages to JDK 17. But for some it make sense to leave them with JDK 11 - instance-migration, old-engine, rolling-update as they test specific scenarios that are not covered with JDK 11 daily stages.

✍️ Let's extend the upgrade guide that to mention that Spring 6 doesn't support JDK 11 and users need to override the spring 6 dependency to with spring 5 to stay if they use JDK11.

@joaquinfelici
Copy link
Contributor Author

joaquinfelici commented Feb 28, 2025

@yanavasileva

  • I added a java11 profile in the qa module to override the spring version for every build with java11.
  • I extended the documentation here.
  • Pipelines are still running 🕐

Copy link
Member

@yanavasileva yanavasileva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Only small improvement in the stage-types.

daily stages run on mysql here: #4965

Co-authored-by: yanavasileva <yanavasileva@users.noreply.github.com>
@joaquinfelici
Copy link
Contributor Author

joaquinfelici commented Mar 4, 2025

Main pipeline is failing due to flakiness in test BuiltinExceptionCodeForeignKeyConstraintViolationTest, all other tests and stages are green.

@joaquinfelici joaquinfelici merged commit c8374f2 into master Mar 4, 2025
6 of 7 checks passed
@joaquinfelici joaquinfelici deleted the 4869-Spring6Bis branch March 4, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-as Runs the builds for all application servers. ci:all-db Runs the builds for all databases. ci:default-build Runs the builds that have no explicit trigger (e.g. different history levels). ci:e2e Runs the frontend end-to-end tests. ci:jdk Runs the builds for all supported Java versions. ci:migration Runs the process instance migration builds. ci:rest-api Runs extra builds for the REST API (currently only WLS compatibility builds). ci:rolling-update Runs the rolling update builds. ci:spring-boot Runs the integration tests for the Spring Boot starter. ci:webapp-integration Runs the webapp integration builds.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants