-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(engine): bump spring dependency to version 6 #4952
Conversation
b43829f
to
f53c4ba
Compare
d1459e8
to
b14b489
Compare
c3a22e2
to
a54cef9
Compare
97cd806
to
792a8da
Compare
Hints for reviewThe spring 6 upgrade hasn't changed since the original reverted PR. All new changes are related to CI or QA modules. CI / QA
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Many of the QA DB tests
stages are not run by default in the PR even with labels. I expect failures for migration, large, since the JDK 11 there.
📓 General note, as long as we have JDK 11 daily stages, we are fine to move most of the stages to JDK 17. But for some it make sense to leave them with JDK 11 - instance-migration
, old-engine
, rolling-update
as they test specific scenarios that are not covered with JDK 11 daily stages.
✍️ Let's extend the upgrade guide that to mention that Spring 6 doesn't support JDK 11 and users need to override the spring 6 dependency to with spring 5 to stay if they use JDK11.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good. Only small improvement in the stage-types
.
daily stages run on mysql here: #4965
Co-authored-by: yanavasileva <yanavasileva@users.noreply.github.com>
Main pipeline is failing due to flakiness in test |
Related to #4869
Duplicate of #4862 (reverted) created for CI fixes