-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(content): Add Quarkus 3.14 Updates to Docs #1675
Conversation
- generic-config suffix is added to process-engine, job-executor properties Related-to: camunda/camunda-bpm-platform#4163
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 This is very good already. I was wondering if we could provide a little more background information to our users about why we decided to introduce a breaking change.
Co-authored-by: Miklas Boskamp <20189772+mboskamp@users.noreply.github.com>
Hello @christinaausley, I'd like to kindly request your input for changes in the content, style or any other contribution you can think of for this pull request. Context: If there is anything you'd like to change, feel free to add your suggestions. Thank you in advance, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor non-blocking suggestions - otherwise this looks good to me from a docs perspective!
Co-authored-by: Cole Isaac <82131455+conceptualshark@users.noreply.github.com>
|
||
- `quarkus.camunda.enforce-history-time-to-live` **becomes** `quarkus.camunda.generic-config.enforce-history-time-to-live` | ||
|
||
- `quarkus.camunda.job-executor.thread-pool.max-pool-size` **becomes** `quarkus.camunda.job-executor.generic-config.thread-pool.max-pool-size` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @psavidis ,
I was checking these changes, and I may be missing something, but isn't this incorrect?
Only non specific properties that are mapped to the genericConfig
map should be impacted. This shouldn't include properties:
job-executor.thread-pool.max-pool-size
job-executor.thread-pool.queue-size
We can see here that these two properties haven't changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The above is correct 👍
Indeed the job executor properties are a poor selection for demonstrating the change in the docs
Proof: Changing the values in the test file mixed-application.properties makes CamundaEngineConfigFileTest#L70 fail which means the properties are mapped correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for checking. In that case changes in file configuration.md are also incorrect. I can correct these in a new PR to prepare for the 3.15 upgrade.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised this PR for addressing the corrections.
Related-to: camunda/camunda-bpm-platform#4163