chore(docs): updated google tag manager link via themes build #1694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venetrius
commented
Nov 5, 2024
| @@ -8,7 +8,7 @@ | |||
| </p> | |||
|
|
|||
| <p> | |||
| <a href="http://camunda.org">camunda.org</a> and <a href="{{ .Site.BaseURL }}">docs.camunda.org</a> are part of Camunda 7 | |||
| <a href="http://camunda.org">camunda.org</a> and <a href="{{ .Site.BaseURL }}">docs.camunda.org</a> are both part of Camunda | |||
There was a problem hiding this comment.
File was out of sync, changes in themes repo are later
Changes from docs-manual 2024.02.21:
e6f59b6
Changed in themes 2024.03.05:
venetrius
commented
Nov 5, 2024
| @@ -5,7 +5,7 @@ | |||
| <script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start': | |||
| new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0], | |||
| j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src= | |||
| 'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); | |||
| 'https://ssgtm.camunda.org/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f); | |||
venetrius
commented
Nov 5, 2024
| <h4>Standalone Web Application</h4> | ||
| <h4></h4> | ||
|
|
||
| <p class="hint"></p> |
There was a problem hiding this comment.
For both changes in this file
camunda-docs-manual was out of sync with themes. This was updated in themes last year: camunda/camunda-docs-theme@48e728b#diff-bc15f369d7bd69fe8cfecb4b6ad5e48f6b37ca6944344ad415ffd960024399b5L70
venetrius
commented
Nov 5, 2024
venetrius
commented
Nov 6, 2024
| @@ -34,13 +34,6 @@ | |||
| {{ $styles := resources.Get "css/docs.css" | fingerprint }} | |||
|
|
|||
| <link rel="stylesheet" href="{{ $styles.Permalink }}" integrity="{{ $styles.Data.Integrity }}"> | |||
| {{- $permalink := .Permalink }} | |||
There was a problem hiding this comment.
Synced from themes
See: camunda/camunda-docs-theme#50 (comment)
venetrius
added a commit
that referenced
this pull request
Nov 13, 2024
venetrius
added a commit
that referenced
this pull request
Nov 13, 2024
venetrius
added a commit
that referenced
this pull request
Nov 13, 2024
venetrius
added a commit
that referenced
this pull request
Nov 13, 2024
This was referenced Nov 13, 2024
venetrius
added a commit
that referenced
this pull request
Nov 25, 2024
venetrius
added a commit
that referenced
this pull request
Nov 25, 2024
venetrius
added a commit
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to: camunda/team-automation-platform/issues/160