Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ You mentioned
Spring 5 is still supported but must be explicitly overridden. Websphere Liberty and other impacted distros continue using spring 5
. Do we still support it outside of WLS or WAS? If so, are there any tests for it? If not, do you think it makes sense to specify that Spring 5 is still used for WLS and WAS, but all other environments and the default artifacts only support Spring 6 now?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, the engine will still be "compatible" with both spring 5 and spring 6. The compatibility is still tested through the
camunda-engine-spring
(spring 5) and thecamunda-engine-spring-6
(spring 6) modules. These are mentioned here. The change in the distros is about makingspring-beans
optional (these are transitively used by wls and was), the version of spring the distros use derives on whatcamunda-engine-spring
module they use, and this hasn't changed.