Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add overviews to bpmn elements #3137

Merged
merged 6 commits into from
Feb 20, 2024
Merged

add overviews to bpmn elements #3137

merged 6 commits into from
Feb 20, 2024

Conversation

christinaausley
Copy link
Contributor

Description

Related to https://github.com/bpmn-io/internal-docs/issues/805.

@philippfromme Let me know what you think here. Once approved, I can backport.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@christinaausley christinaausley added the component:modeler Issues related with Modeler project label Dec 29, 2023
@christinaausley christinaausley self-assigned this Dec 29, 2023
@christinaausley
Copy link
Contributor Author

Related to https://github.com/bpmn-io/internal-docs/issues/805.

@philippfromme Let me know what you think here. Once approved, I can backport as I see the issue is now closed.

@akeller
Copy link
Member

akeller commented Feb 2, 2024

Need any help here? This looks stalled.

@christinaausley
Copy link
Contributor Author

@philippfromme @CatalinaMoisuc mind having a quick review here sometime this week?

@philippfromme
Copy link
Contributor

@christinaausley I will have a look today! 👀

Copy link
Contributor

github-actions bot commented Feb 8, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley marked this pull request as ready for review February 13, 2024 19:10
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good now! 👏🏻

@CatalinaMoisuc
Copy link
Member

@philippfromme @christinaausley I assume that this PR can be merged since it was already reviewed by one bpmn.io core expect, no need for an extra review from my side, correct?

@christinaausley christinaausley merged commit 77b4206 into main Feb 20, 2024
6 checks passed
@christinaausley christinaausley deleted the add-bpmn-overview branch February 20, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:modeler Issues related with Modeler project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants