Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(web-modeler): document relationship between subject claim and Web Modeler resources #3196

Merged
merged 4 commits into from
Feb 12, 2024
Merged

docs(web-modeler): document relationship between subject claim and Web Modeler resources #3196

merged 4 commits into from
Feb 12, 2024

Conversation

wollefitz
Copy link
Member

@wollefitz wollefitz commented Jan 10, 2024 •
edited
Loading

Description

Closes https://github.com/camunda/web-modeler/issues/7583
Closes https://github.com/camunda/web-modeler/issues/7584
Closes https://github.com/camunda/web-modeler/issues/5792

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@wollefitz wollefitz added component:modeler Issues related with Modeler project hold This issue is parked, do not merge. labels Jan 10, 2024
@wollefitz wollefitz self-assigned this Jan 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 10, 2024 •
edited
Loading

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@wollefitz wollefitz force-pushed the web-modeler-7583-keycloak-subject branch from 3a75dd0 to 30dd3a3 Compare January 10, 2024 15:54
@christinaausley
Copy link
Contributor

@wollefitz Let me know when you are ready for final review here 👍

@wollefitz
Copy link
Member Author

@wollefitz Let me know when you are ready for final review here 👍

Hey @christinaausley ! This PR depends on #3190. Once it's merged, this PR can be rebased & reviewed.

@wollefitz wollefitz force-pushed the 2312-web-modeler-backup-and-restore branch 2 times, most recently from e192880 to a8c4517 Compare January 29, 2024 19:46
Base automatically changed from 2312-web-modeler-backup-and-restore to main January 30, 2024 15:28
@wollefitz wollefitz force-pushed the web-modeler-7583-keycloak-subject branch from 30dd3a3 to 4bb2afc Compare January 30, 2024 18:46
@wollefitz wollefitz removed the hold This issue is parked, do not merge. label Jan 30, 2024
@wollefitz wollefitz marked this pull request as ready for review January 30, 2024 18:47
@wollefitz
Copy link
Member Author

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.4/.

Will do so after reviews.

@wollefitz wollefitz added component:web-modeler-sm Issues related with Web Modeler Self-Managed and removed component:modeler Issues related with Modeler project labels Feb 1, 2024
christinaausley
christinaausley reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see some variances between ID and id, but I do have an issue in the backlog for this.

Also, non-blocking, but if you could add this to the Optimize sidebar, that would also be fantastic!

Technical review in latest commit 👍

jfriedenstab
jfriedenstab requested changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@jfriedenstab jfriedenstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just a few minor comments.

@wollefitz wollefitz force-pushed the web-modeler-7583-keycloak-subject branch 2 times, most recently from 8ff9e80 to de3471f Compare February 12, 2024 09:43
@wollefitz
Copy link
Member Author

Also, non-blocking, but if you could add this to the Optimize sidebar, that would also be fantastic!

Done ✅

Also backported the changes to the previous versions.

jfriedenstab
jfriedenstab approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@jfriedenstab jfriedenstab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my end! 👍🏻

@wollefitz wollefitz force-pushed the web-modeler-7583-keycloak-subject branch from de3471f to 67a6361 Compare February 12, 2024 11:38
@wollefitz wollefitz changed the title docs(web-modeler): document relationship between subject claim and We… docs(web-modeler): document relationship between subject claim and Web Modeler resources Feb 12, 2024
@wollefitz wollefitz enabled auto-merge (squash) February 12, 2024 12:07
@wollefitz wollefitz merged commit 9302f73 into main Feb 12, 2024
7 checks passed
@wollefitz wollefitz deleted the web-modeler-7583-keycloak-subject branch February 12, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfriedenstab jfriedenstab jfriedenstab approved these changes

@christinaausley christinaausley Awaiting requested review from christinaausley

Assignees

@wollefitz wollefitz

Labels
component:web-modeler-sm Issues related with Web Modeler Self-Managed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wollefitz @christinaausley @jfriedenstab