Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zeebe tokenScope w/ postfix to MSFT Entra doc #3285

Merged
merged 12 commits into from
Feb 15, 2024

Conversation

akeller
Copy link
Member

@akeller akeller commented Feb 2, 2024

Description

Fixes based on internal thread - https://camunda.slack.com/archives/C06112NS4GJ/p1706820186764449

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@akeller akeller added component:identity Issues related with Identity project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Feb 2, 2024
@akeller akeller self-assigned this Feb 2, 2024
Copy link
Contributor

github-actions bot commented Feb 2, 2024

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

Ben-Sheppard
Ben-Sheppard previously approved these changes Feb 12, 2024
Copy link
Contributor

@Ben-Sheppard Ben-Sheppard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my perspective I think these changes are good to go, I left two comments that are NABD from my side but I'm keen to unblock and make progress on the docs so I'm approving :)

```json
"accessTokenAcceptedVersion": 2,
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if in here, although its not directly related to this PR, we could add a note to say that the Identity UI is not available in this version? We can then remove this for 8.5 which is when the Identity UI is being introduced?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ben-Sheppard can you add that in a separate PR or issue? It would be up to you and the Identity team to remember to remove it for 8.5. Is there an epic you can associate this with?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea sure, I can raise a PR and then track it

@akeller
Copy link
Member Author

akeller commented Feb 13, 2024

@Ben-Sheppard @wollefitz any remaining changes here? Is this good to backport (just to 8.4)?

@wollefitz
Copy link
Member

@wollefitz any remaining changes here? Is this good to backport (just to 8.4)?

Looks good to me and good to be backported to 8.4

Copy link
Contributor

@Ben-Sheppard Ben-Sheppard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one final change from my side and then all looks good :)

@akeller akeller marked this pull request as ready for review February 14, 2024 15:08
@akeller akeller requested a review from Ben-Sheppard February 14, 2024 15:08
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but creating an issue in my backlog as to whether we refer to steps as "Step 1" or "step 1", bolding, etc.

Creating this as a separate issue as we may have additional instances in the docs where this isn't consistent 👍

@akeller akeller merged commit cd77e76 into main Feb 15, 2024
6 checks passed
@akeller akeller deleted the entra-docs-zeebe-tokenscope branch February 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:identity Issues related with Identity project component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants