-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zeebe tokenScope w/ postfix to MSFT Entra doc #3285
Conversation
👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉 You can read more about the versioning within our docs in our documentation guidelines. |
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Outdated
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Show resolved
Hide resolved
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective I think these changes are good to go, I left two comments that are NABD from my side but I'm keen to unblock and make progress on the docs so I'm approving :)
```json | ||
"accessTokenAcceptedVersion": 2, | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if in here, although its not directly related to this PR, we could add a note to say that the Identity UI is not available in this version? We can then remove this for 8.5 which is when the Identity UI is being introduced?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ben-Sheppard can you add that in a separate PR or issue? It would be up to you and the Identity team to remember to remove it for 8.5. Is there an epic you can associate this with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea sure, I can raise a PR and then track it
…onnect-to-an-oidc-provider.md
…onnect-to-an-oidc-provider.md
@Ben-Sheppard @wollefitz any remaining changes here? Is this good to backport (just to 8.4)? |
Looks good to me and good to be backported to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one final change from my side and then all looks good :)
docs/self-managed/platform-deployment/helm-kubernetes/guides/connect-to-an-oidc-provider.md
Outdated
Show resolved
Hide resolved
…nda/camunda-docs into entra-docs-zeebe-tokenscope
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but creating an issue in my backlog as to whether we refer to steps as "Step 1" or "step 1", bolding, etc.
Creating this as a separate issue as we may have additional instances in the docs where this isn't consistent 👍
Description
Fixes based on internal thread - https://camunda.slack.com/archives/C06112NS4GJ/p1706820186764449
When should this change go live?
hold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.