-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(web-modeler): document file download and export options #3309
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.4/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM - I suggested some ways to clarify the value and shorten the text. Overall, the UI for this kind of feature should be self-explanatory enough that documentation can be light. The main 'gotchas' were covered nicely: the download limit and different behavior between project view and file editor view.
You do not need to re-request my review.
Co-authored-by: Eric Lundberg <ericlundberg09@gmail.com>
Co-authored-by: Eric Lundberg <ericlundberg09@gmail.com>
Thanks @HanselIdes! 👍🏻 I've adopted your suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice writing here!
@HanselIdes To allow me to merge the PR, I think you need to approve it (because you requested changes). |
Description
Documents the file download and export options in Web Modeler.
Part of https://github.com/camunda/product-hub/issues/1959.
Closes https://github.com/camunda/web-modeler/issues/5286.
When should this change go live?
8.5.0-alpha1
release date) (applyhold
label or convert to draft PR)?PR Checklist
/versioned_docs
directory, or they are not for an already released version./docs
directory (aka/next/
), or they are not for future versions.