Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(formatting): retro review 3147 #3312

Merged
merged 1 commit into from
Feb 13, 2024
Merged

style(formatting): retro review 3147 #3312

merged 1 commit into from
Feb 13, 2024

Conversation

christinaausley
Copy link
Contributor

@christinaausley christinaausley commented Feb 12, 2024

Description

Closes #3159. To add casing guidelines to WCoE at next release.

The casing here really aligned by chance with what Red (Rad) Hat does by its product naming to help distinguish the terminology references from one another.

"NGINX Ingress Controller" and "ingress-nginx controller" really helps distinguish between the two, but let me know if you have additional thoughts or questions.

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@christinaausley christinaausley added component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed labels Feb 12, 2024
@christinaausley christinaausley self-assigned this Feb 12, 2024
@akeller akeller merged commit a186b28 into main Feb 13, 2024
11 checks passed
@akeller akeller deleted the 3159-retro-review branch February 13, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content component:self-managed Docs and issues related to Camunda Platform 8 Self-Managed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Retro review #3147
3 participants