Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add decisionInstanceKey to EvaluateDecisionResponse in gateway service #3315

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add decisionInstanceKey to EvaluateDecisionResponse in gateway service #3315

merged 1 commit into from
Feb 15, 2024

Conversation

korthout
Copy link
Member

@korthout korthout commented Feb 13, 2024 •
edited
Loading

Description

With the upcoming 8.5.0-alpha2, the Zeebe gateway can respond the decision instance key of an evaluated decision in gRPC. This can be useful to look up the evaluated decision in Operate.

See camunda/camunda#16320
And camunda/camunda#15916

When should this change go live?

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@korthout
docs(api): add decisionInstanceKey to gateway
209e8b3 
The Zeebe gateway can now respond the decision instance key of an
evaluated decision in gRPC. This can be useful to lookup the evaluated
decision in Operate.
@github-actions GitHub Actions
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.4/.

  • docs/apis-tools/zeebe-api/gateway-service.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

tmetzke
tmetzke approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@tmetzke tmetzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me

@christinaausley
Copy link
Contributor

@korthout Should this maintain a hold label until next release? Love the early bird work here!

@korthout
Copy link
Member Author

korthout commented Feb 15, 2024 •
edited
Loading

@christinaausley That depends a bit on how strict you think the documentation in Next should be. Is it strictly only the current latest alpha or also already the upcoming alpha? In the past, we weren't strict with it.

This is for 8.5.0-alpha2, but is already merged and available on the latest snapshot version.

@christinaausley christinaausley merged commit c26f411 into main Feb 15, 2024
10 checks passed
@christinaausley christinaausley deleted the korthout-decision-instance-key branch February 15, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmetzke tmetzke tmetzke approved these changes

@christinaausley christinaausley Awaiting requested review from christinaausley

Assignees

@korthout korthout

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korthout @christinaausley @tmetzke