Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: audience in MS Entra is inherited from client id #5144

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jonathanlukas
Copy link
Contributor

@jonathanlukas jonathanlukas commented Mar 4, 2025

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:
    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

@jonathanlukas jonathanlukas self-assigned this Mar 4, 2025
Copy link
Contributor

github-actions bot commented Mar 4, 2025

👋 🤖 ✅ Looks like the changes were ported across versions, nice job! 🎉

You can read more about the versioning within our docs in our documentation guidelines.

@jonathanlukas jonathanlukas enabled auto-merge (squash) March 4, 2025 15:26
@akeller akeller added component:identity Issues related with Identity project kind/bug Issues related with bugs in the documentation labels Mar 4, 2025
@akeller
Copy link
Member

akeller commented Mar 4, 2025

I have no context for this change, but I adjusted the PR description and added a bug label.

@conceptualshark
Copy link
Contributor

This is currently being updated in #5063, which also includes a few other changes.

@jonathanlukas jonathanlukas disabled auto-merge March 7, 2025 13:28
@jonathanlukas
Copy link
Contributor Author

Thank you @conceptualshark . I will wait for #5063 then.

@jonathanlukas jonathanlukas added the hold This issue is parked, do not merge. label Mar 7, 2025
@jonathanlukas jonathanlukas force-pushed the jonathanlukas-patch-1 branch from c698409 to 776db07 Compare March 11, 2025 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:identity Issues related with Identity project hold This issue is parked, do not merge. kind/bug Issues related with bugs in the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants