Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 8.8 and 8.7 announcements links #5152

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Conversation

mesellings
Copy link
Contributor

Description

Fixes and aligns the mini-toc links on the 8.7 and 8.8 announcements pages, as per #5067.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:
    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

@mesellings mesellings added the 8.7.0-alpha5 March 2025 alpha release label Mar 5, 2025
@mesellings mesellings requested a review from a team March 5, 2025 17:25
@mesellings mesellings self-assigned this Mar 5, 2025
@mesellings mesellings requested a review from akeller March 5, 2025 17:25
Copy link
Contributor

github-actions bot commented Mar 5, 2025

👋 🤖 🤔 Hello, @mesellings! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.

  • docs/reference/announcements.md
  • docs/reference/announcements/870.md
  • docs/reference/announcements/880.md
These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.7/.
  • docs/reference/announcements/880.md
These files were changed only in versioned_docs/version-8.7/. You might want to duplicate these changes in versioned_docs/version-8.6/.
  • versioned_docs/version-8.7/reference/announcements.md
  • versioned_docs/version-8.7/reference/announcements/870.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

Copy link
Contributor

@conceptualshark conceptualshark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely got tangled up - thank you for the alignment! Good things to think about with the announcements restructuring - these are a lot of places to keep updated and in sync (and currently done twice over for the 8.7/8.8 split!).

- [Web Modeler Deploy diagram change](/reference/announcements/870.md#web-modeler-deploy-diagram-change)
- [Southwest Asia for SaaS region](/reference/announcements/870.md#southeast-asia-region-for-saas-customers-saas)
- [Web Modeler](/reference/announcements/870.md#web-modeler)
- [Southeast Asia region for SaaS customers](/reference/announcements/870.md#southeast-asia-region-for-saas-customers-saas)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this east/west change!!

@mesellings
Copy link
Contributor Author

@akeller @conceptualshark did you want me to do a follow-up PR to change the heading anchor links to use manual links? I was going to here but wasn't sure if these were linked to already, so didn't want to break any existing links?

@mesellings mesellings merged commit 26fbcf7 into main Mar 5, 2025
12 checks passed
@mesellings mesellings deleted the fix-announcement-links branch March 5, 2025 17:39
@akeller
Copy link
Member

akeller commented Mar 5, 2025

@akeller @conceptualshark did you want me to do a follow-up PR to change the heading anchor links to use manual links? I was going to here but wasn't sure if these were linked to already, so didn't want to break any existing links?

@mesellings 😬 Can you create a separate issue for this so we can discuss the concerns with breaking existing links? My immediate concern is the blog, but I don't know how granular those links are and we can request a fix/update from that team.

@mesellings
Copy link
Contributor Author

@akeller @conceptualshark did you want me to do a follow-up PR to change the heading anchor links to use manual links? I was going to here but wasn't sure if these were linked to already, so didn't want to break any existing links?

@mesellings 😬 Can you create a separate issue for this so we can discuss the concerns with breaking existing links? My immediate concern is the blog, but I don't know how granular those links are and we can request a fix/update from that team.

See #5168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.7.0-alpha5 March 2025 alpha release
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

8.7 Announcements page is inconsistent across 8.7 and 8.8 versions
3 participants