-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(data-purge): adds operational guide for data purge #5180
base: main
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello, @npepinpe! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, just some suggestions :)
description: "Purge data from your cluster" | ||
--- | ||
|
||
The data purge feature allows you to delete all runtime and historical data from your cluster. This operation resets the cluster to an empty state while maintaining the original topology. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 We should emphasize the latter part - while yes it deletes data, it's more that it restores the cluster to a "fresh" state. So there will be some things there after - e.g. the default user (if so configured), default tenant, some schema metadata, etc.
<details> | ||
<summary>Example response</summary> | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❓ Is the syntax highlighting automatic, or do we need to add json
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like I have taken one of the only sites as a model, where this was not done :)
I'll add it.
:::danger | ||
The purge operation is irreversible. It will delete the runtime data in the cluster and the historical data in the exporters! Make sure to back up your data before proceeding. | ||
::: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔧 Can we add a section either at the top or the end, which puts it all together? For example, I want to purge, so I would send the POST request, grab the change ID, and then poll the cluster via GET until my change ID is the last completed one. I think that's really helpful for users if we can "put it all together" in a runbook like format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that the runbook style is good for the user. I had hoped that the current versions already accomplishes that.
I fear that if I include that, it feels like there is too much repetition, because the current structure is already close to that.
The screenshot is from a relatively small screen (23"), when scrolled to the "Purge data" paragraph. The runbook should come after the "Danger" block, so if people have already scrolled until there, they can already see both steps involved, even on a smaller screen.
I could get rid of some of the explanations regarding the output, which I copied from the Cluster Scaling doc, and just reference it. That would make it more compact and less noisy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No no, I liked all of the content so far - I was just thinking, how about we put a "TL;DR" kind of section at the top, which shows usage of both requests together to achieve a "complete" purge, e.g.
changeId=$(curl -XPOST http://localhost:9600/actuator/cluster/purge | jq '.changeId')
lastCompletedChangeId=-1
while [ $changeId -neq $lastCompletedChangeId ] do;
lastCompletedChangeId=$(curl http://locahost:9600/actuator/cluster | jq '.lastCompletedChangeId')
echo "Last completed change ID ${lastCompletedChangeId} == ${changeId}?"
sleep 1
done
Don't use the above, it probably doesn't work 😄 But just to get the idea. Explain how one could purge and wait until it's complete, i.e. the expected usage together. Does that make sense?
🚧 The preview environment for the commit d96da38 is being built. This usually takes 15-20 minutes. |
Description
This PR describes the new cluster data purge functionality described here: #25861
When should this change go live?
bug
orsupport
label)available & undocumented
label)hold
label)low prio
label)PR Checklist
My changes are for an upcoming minor release and:
/docs
directory (version 8.8)./versioned_docs/version-8.7/
directory (version 8.7).My changes are for an already released minor and are in a
/versioned_docs
directory.I included my new page in the sidebar file(s).
I added a redirect for a renamed or deleted page to the .htaccess file.
I added a DRI, team, or delegate as a reviewer for technical accuracy and grammar/style:
@camunda/tech-writers
unless working with an embedded writer.