Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration to match PKCS12 support #5181

Merged
merged 4 commits into from
Mar 7, 2025
Merged

Conversation

npepinpe
Copy link
Member

@npepinpe npepinpe commented Mar 7, 2025

Description

This PR fixes the documentation around broker/gateway configuration support for PKCS12 keystores. Parts were missing in the general configuration overview, while in others we referenced the wrong environment variables.

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support. (add bug or support label)
  • This is already available but undocumented and should be released within a week. (add available & undocumented label)
  • This is on a specific schedule and the assignee will coordinate a release with the DevEx team. (create draft PR and/or add hold label)
  • This is part of a scheduled alpha or minor. (add alpha or minor label)
  • There is no urgency with this change (add low prio label)

PR Checklist

  • My changes are for an upcoming minor release and:

    • are in the /docs directory (version 8.8).
    • are in the /versioned_docs/version-8.7/ directory (version 8.7).
  • My changes are for an already released minor and are in a /versioned_docs directory.

  • I added a DRI, team, or delegate as a reviewer for technical accuracy and grammar/style:

@npepinpe npepinpe self-assigned this Mar 7, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@npepinpe npepinpe force-pushed the np-fix-doc-pkcs12 branch from 7a40c08 to 32b394a Compare March 7, 2025 11:38
Copy link
Member

@koevskinikola koevskinikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@npepinpe npepinpe merged commit 0235993 into main Mar 7, 2025
8 checks passed
@npepinpe npepinpe deleted the np-fix-doc-pkcs12 branch March 7, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants