Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Literal expression editor styles broken #4550

Closed
philippfromme opened this issue Sep 25, 2024 · 9 comments · Fixed by #4622
Closed

Literal expression editor styles broken #4550

philippfromme opened this issue Sep 25, 2024 · 9 comments · Fixed by #4622
Assignees
@jarekdanielak
Labels
bug Something isn't working DMN ui
Milestone
M82

Comments

@philippfromme
Copy link
Contributor

Describe the bug

The styles of the literal expression editor are broken.

5.28

Camunda_Modeler_cUyDlre0ni

5.26

Camunda_Modeler_k6mwsTJHwg

Steps to reproduce

  1. Open literal expression editor
  2. Styles broken

Expected behavior

Styles not broken.

Environment

  • Camunda Modeler Version: 5.28-rc.1

Additional context

No response
@philippfromme philippfromme added the bug Something isn't working label Sep 25, 2024
@barmac
Copy link
Collaborator

barmac commented Sep 25, 2024

Styles break only after you open a BPMN diagram.

@barmac
Copy link
Collaborator

barmac commented Sep 25, 2024

Screen.Recording.2024-09-25.at.11.14.57.mov

@barmac
Copy link
Collaborator

barmac commented Sep 25, 2024

Reproducible in 5.27:
image

@barmac
Copy link
Collaborator

barmac commented Sep 25, 2024

I suspect that BPMN styles introduce some CSS reset. Unfortunately, the DMN editor relies on the default user agent styles in multiple places.

@barmac
Copy link
Collaborator

barmac commented Sep 25, 2024

Notice that the problem exists in the Web Modeler too:
image

This was referenced Sep 26, 2024
Closed
Closed
@nikku
Copy link
Member

nikku commented Oct 1, 2024 •
edited
Loading

Related to #4555.

Moving to ready to discuss.

@nikku nikku added ready Ready to be worked on DMN ui labels Oct 1, 2024
This was referenced Oct 14, 2024
Open
Merged
@jarekdanielak
Copy link
Contributor

The reason is the carbon style, as I described in my comment to a pull request that closes a similar issue on welcome page.

I created an issue where we can discuss it and a PR with a hotfix.

bpmn-io/variable-outline#4

@jarekdanielak jarekdanielak added the in progress Currently worked on label Oct 14, 2024 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the ready Ready to be worked on label Oct 14, 2024
jarekdanielak added a commit to bpmn-io/dmn-js that referenced this issue Oct 18, 2024
@jarekdanielak
fix: make literal expression variables table styles explicit
3f271ec 
Related to camunda/camunda-modeler#4550
@jarekdanielak
Copy link
Contributor

Fixed upstream in bpmn-io/dmn-js#907

@jarekdanielak jarekdanielak added the fixed upstream Requires integration of upstream change label Oct 18, 2024 — with bpmn-io-tasks
@jarekdanielak jarekdanielak removed the in progress Currently worked on label Oct 18, 2024
@nikku
Copy link
Member

nikku commented Oct 18, 2024

@jarekdanielak Let's release + integrate the fix for this.

@jarekdanielak jarekdanielak mentioned this issue Oct 18, 2024
Merged
4 tasks
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed fixed upstream Requires integration of upstream change labels Oct 18, 2024
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 24, 2024
@github-actions github-actions bot added this to the M82 milestone Oct 24, 2024
@jarekdanielak jarekdanielak mentioned this issue Oct 29, 2024
Closed
38 tasks
github-merge-queue bot pushed a commit to camunda/camunda that referenced this issue Nov 25, 2024
@renovate
deps: Update dependency dmn-js to v16.8.2 (main) (#25179)
d5fb4c3 
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [dmn-js](https://redirect.github.com/bpmn-io/dmn-js)
([source](https://redirect.github.com/bpmn-io/dmn-js/tree/HEAD/packages/dmn-js))
| [`16.7.1` ->
`16.8.2`](https://renovatebot.com/diffs/npm/dmn-js/16.7.1/16.8.2) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/dmn-js/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/dmn-js/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/dmn-js/16.7.1/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/dmn-js/16.7.1/16.8.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bpmn-io/dmn-js (dmn-js)</summary>

###
[`v16.8.2`](https://redirect.github.com/bpmn-io/dmn-js/blob/HEAD/packages/dmn-js/CHANGELOG.md#1682)

[Compare
Source](https://redirect.github.com/bpmn-io/dmn-js/compare/v16.8.1...v16.8.2)

- `FIX`: make name change behavior not break on name change
([#&#8203;917](https://redirect.github.com/bpmn-io/dmn-js/pull/917))

###
[`v16.8.1`](https://redirect.github.com/bpmn-io/dmn-js/blob/HEAD/packages/dmn-js/CHANGELOG.md#1681)

[Compare
Source](https://redirect.github.com/bpmn-io/dmn-js/compare/v16.8.0...v16.8.1)

- `FIX`: make literal expression editor hitbox bigger in BKM
([camunda/camunda-modeler#4545](https://redirect.github.com/camunda/camunda-modeler/issues/4545))
- `FIX`: make literal expression variables table styles explicit
([camunda/camunda-modeler#4550](https://redirect.github.com/camunda/camunda-modeler/issues/4550))

###
[`v16.8.0`](https://redirect.github.com/bpmn-io/dmn-js/blob/HEAD/packages/dmn-js/CHANGELOG.md#1680)

[Compare
Source](https://redirect.github.com/bpmn-io/dmn-js/compare/v16.7.1...v16.8.0)

-   `FEAT`: support Camunda 8 FEEL built-ins
- `FIX`: display parameterless functions suggestion correctly
([#&#8203;898](https://redirect.github.com/bpmn-io/dmn-js/issues/898))
-   `FIX`: improve validation of `first-item` FEEL rule
- `FIX`: variable name changes when element name\label changes
([#&#8203;863](https://redirect.github.com/bpmn-io/dmn-js/issues/863))
-   `DEPS`: update to `@bpmn-io/feel-editor@1.9.1`

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/camunda/camunda).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiYXV0b21lcmdlIl19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jarekdanielak jarekdanielak

Labels
bug Something isn't working DMN ui
Projects
None yet
Milestone
M82
Development

Successfully merging a pull request may close this issue.

deps: update dmn-js dependencies camunda/camunda-modeler
4 participants
@nikku @philippfromme @jarekdanielak @barmac