Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update to @camunda/linting@3.34.0 #4876

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

barmac
Copy link
Collaborator

@barmac barmac commented Mar 4, 2025

Proposed Changes

  • DEPS: update to @camunda/linting@3.34.0
  • FIX: make link-event rule check only BPMN compliance (#4870)
  • FIX: do not require start and end events in ad-hoc subprocess (bpmn-io/bpmnlint#176)

Closes #4870

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Mar 4, 2025
@barmac
Copy link
Collaborator Author

barmac commented Mar 4, 2025

I've noticed that we provide a duplicated rule in the plugin, but the one given by bpmnlint does not focus the properties panel:
image

So this needs to be fixed yet.

@barmac
Copy link
Collaborator Author

barmac commented Mar 6, 2025

The bpmnlint/link-event rule reports two errors for a single unnamed link event:

  • missing name (correct)
  • missing matching catch/throw event with missing name (incorrect)

We should ignore unnamed events in the pair-matching flow.

@barmac
Copy link
Collaborator Author

barmac commented Mar 7, 2025

The stock bpmnlint/link-event rule does not attach any metadata to the report, so I need to match error message for proper @camunda/linting integration. I'd rather not have bpmnlint depend on the linting error message types, but that's what enabled to decouple error message from linting integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress Currently worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link event validation is too strict
1 participant