-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: app settings #4885
base: develop
Are you sure you want to change the base?
feat: app settings #4885
Conversation
Some implementation details were discussed in our Hour of Code. |
Good one. This is the same shortcut as in Google Chrome and VSCode. |
Does not work for me (Linux, German keyboard), no shortcut on Linux / Windows exists for Chrome |
Do we want: a) Universal shortcut that works for all platforms, but is not a standard across different apps. I vote B, but I'm slightly biased. 🍎 Btw. the Settings are also available under the File menu. |
@philippfromme How about shortcuts in Windows? |
Know the context. Shortcuts should pick up folks in the domain / context they operate. No value to unify things. Mac user does not care for 🪟 shortcuts. |
Proposed Changes
This lays a foundation for allowing components and plugins to utilize app settings.
Includes:
settings.json
client-test
plugin.To do:
Closes #2913
Related to https://github.com/camunda/product-hub/issues/2491
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}